From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79843C4338F for ; Tue, 17 Aug 2021 20:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 620D660FD9 for ; Tue, 17 Aug 2021 20:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235006AbhHQU2k (ORCPT ); Tue, 17 Aug 2021 16:28:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230515AbhHQU2j (ORCPT ); Tue, 17 Aug 2021 16:28:39 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BE90C061796 for ; Tue, 17 Aug 2021 13:28:05 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id k5so15928756lfu.4 for ; Tue, 17 Aug 2021 13:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=To4Gp542jJmSWD7MdZF3sFHEVTOYykMS63VBniHZYPY=; b=bh2mF/LwnSNjB0vFwgLsICNog5EaVsCuDp6N1PNuDbocaQHr2wlqC5Y+ltDOrFGEN5 u3Z7m+VT7UC2wOgSmWaW7dX9nP/LvrIWTk/0yppmVDoT5+QOBZiIGsJj2OmuPzoeTei4 oILmZeAAMhVG7eW2qWwXU/Hb/OLRew/XWxASU5THx+BrQRMHGD/90BdnmRwSv+pkD9/b Ay/uWSYws4AJWv1n7Bf81YEk50I8wLvI6m8odvtn62SVoJs7HtS3XQYYYf5w6ZCfvLd4 ft9Ml5Ku8Tu9BRE4MbLSeaSGUEA+PP/9x9kWK65bzsnuR5HIdKTS7sk8+UX++4Ht5ELK ICiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=To4Gp542jJmSWD7MdZF3sFHEVTOYykMS63VBniHZYPY=; b=MZPOfGX2jvpDIvn88laCrHVDmFfhxMc14voJp/K/XxWHc6QBeXFKIEapNumNfLyaLn hFXi6mlKbIo4J9ULehsq5Rzj93sG4674r0vDKJ6fP3i9TNEEAvQvjQo5f1+upiUj5dSU EihPHyD4nwS6spKnHylJ6sdooX3S8Pw28VPdTvGTmMiu+T0lgvJxBCoZRU7VmYj6SDJR zVP8lebOkmdKH8bdC7UwS9kdMITOXwjqlmmsleVFU0xlunuWkqyuuV34wSX5iBa6/omR wPOxa/nH6FeQQsuv5a6vPEhxeqcCuNMBb2rp4LQb3tvofoo0ymihnaZSU3qLClWKFoS3 IM+w== X-Gm-Message-State: AOAM530Usiqyiocno7AyxgbUkat0mtmfKeHa+BMyxcgghPIadhN8hazP YRh0ptYVLNQgJCwaViDoCfW+VTBkPgrYsKpjM7RlSA== X-Google-Smtp-Source: ABdhPJyzKPGkscEIAtPNNEn9m7AoHY+m4cnw4vyR4NqDDFeYVO4Cju2uRh5QlVuft9THtbNOB39mT+PFjmHgsr2J1VA= X-Received: by 2002:a05:6512:3286:: with SMTP id p6mr3626973lfe.649.1629232083711; Tue, 17 Aug 2021 13:28:03 -0700 (PDT) MIME-Version: 1.0 References: <20210817174743.541353-1-robh@kernel.org> In-Reply-To: <20210817174743.541353-1-robh@kernel.org> From: Linus Walleij Date: Tue, 17 Aug 2021 22:27:52 +0200 Message-ID: Subject: Re: [PATCH] dt-bindings: PCI: faraday,ftpci100: Fix 'contains' schema usage To: Rob Herring Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , Bjorn Helgaas , linux-pci Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 17, 2021 at 7:47 PM Rob Herring wrote: > The 'contains' keyword applies to elements within an array, so > using 'items' only makes sense if the elements of the array are another > array which is not the case for 'compatible' properties. > > Looking at the driver, it seems the intent was the condition should be > true when 'faraday,ftpci100' is present, so we can drop > 'cortina,gemini-pci'. > > Fixes: 2720b991337d ("dt-bindings: PCI: ftpci100: convert faraday,ftpci100 to YAML") > Cc: Bjorn Helgaas > Cc: Linus Walleij > Cc: linux-pci@vger.kernel.org > Signed-off-by: Rob Herring Reviewed-by: Linus Walleij Yours, Linus Walleij