From: Linus Walleij <linus.walleij@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>,
devicetree <devicetree@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Jan Kotas <jank@cadence.com>,
kernel@pyra-handheld.com
Subject: Re: [Letux-kernel] [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel
Date: Tue, 2 Apr 2019 11:18:39 +0700 [thread overview]
Message-ID: <CACRpkdaqz+_j_n0kuduGqOb38W6ETyOzUgaiZVX3CQWXN2_zbQ@mail.gmail.com> (raw)
In-Reply-To: <20190330193259.5054655e@aktux>
On Sun, Mar 31, 2019 at 1:33 AM Andreas Kemnade <andreas@kemnade.info> wrote:
> > > But I fixed it in that case by introducing a spi-cs-high into the DTS file:
> > > https://marc.info/?l=linux-arm-kernel&m=155292310015309&w=2
> >
> > Yes, that of course works and is our temporary solution.
> >
> > And I see that you also have it on the controller node and not the slave node.
> >
> So if I get it right is a check added for undocumented properties
> (nothing about spi-cs-high in controller node in the bindings
> documentation, only in the slave node) in the two patches mentioned.
>
> And then you add that undocumented property to a dts file in your "fix".
>
> That all sounds strange to me.
Yeah it sounds strange because it is strange :)
I was simply confused and wrong. Sometimes we all do very uniformed
things, today it was me.
The flag should of course be on the slave node.
So now I have to fix my fix.
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-04-02 4:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7509BFB6-36E4-441A-9F16-7A4FEE7F7CF3@goldelico.com>
2019-03-23 14:40 ` [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel H. Nikolaus Schaller
2019-03-24 4:15 ` Linus Walleij
2019-03-24 6:56 ` H. Nikolaus Schaller
2019-03-30 18:33 ` [Letux-kernel] " Andreas Kemnade
2019-03-30 20:10 ` H. Nikolaus Schaller
2019-04-02 4:18 ` Linus Walleij [this message]
2019-04-02 4:02 ` Linus Walleij
2019-04-02 5:05 ` H. Nikolaus Schaller
2019-04-02 5:31 ` Mark Brown
2019-04-02 6:37 ` H. Nikolaus Schaller
2019-04-02 9:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaqz+_j_n0kuduGqOb38W6ETyOzUgaiZVX3CQWXN2_zbQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=jank@cadence.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).