From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B087C433FE for ; Mon, 21 Nov 2022 13:57:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231448AbiKUN5Z (ORCPT ); Mon, 21 Nov 2022 08:57:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231566AbiKUN5E (ORCPT ); Mon, 21 Nov 2022 08:57:04 -0500 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C988DC6073 for ; Mon, 21 Nov 2022 05:56:43 -0800 (PST) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-3a4c2c83300so18077767b3.13 for ; Mon, 21 Nov 2022 05:56:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jlH/ifTu/FLTB5L1spq7VRw6rvpie65so4YRzgc4QSI=; b=akLiFosYnQJXe9tkoa/OWBXS5ptfSIap3HYVKtyInGNBTYXRzhOzhnKUAPq/b8HSZb rOwe/TSon6bjcMKApslR+Sya8nCJIFWezKRMW4OUlHfAe2aspilZLroUh9BLNByI3qyd PUzgUYoVOOkuiirFatTo6LKqq+iaB3PnQOOySgtwThKojiGLAduKIuBdZfn/JG3CwFTX pdcO5leUF4CzQT9PJhwm1OYXpzIKoFfcZLfNSO1RUdx3by0LRyQtY1u/YFZyX2W1KU7a g36W4Aa0kYrCyry39il7ryM4J3m3hRffSh8cMZn4U7gv6qVLyEIqBAGVIqpsy/hhici1 F2uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jlH/ifTu/FLTB5L1spq7VRw6rvpie65so4YRzgc4QSI=; b=1Jc8zOoI32Ra8dWEbrUSDGXiV4ZwfEkNgT19FrYuwfY9YbSqVrD+BYGf3DauZd3p+9 hT74gMk1nj6+pVnuyIYIxg2aA+l3N9kV/m84X59FlhsNJUaX2d7PpFZga74TL29ayEdN MLiTGZthm1ZRSTad1Sb+/D2wU33Fm4u32vL1jJxWk6QAC9aIgCZwucN//pS1LKTQLrTZ mpAItQviBCSX03aEIdfk9LQlqrKbbBPgR90kljYu8CiMDJyx/tIHtaxmnjGDK/U8YixI tu84muh0CXOIVCT1cuX9qaRnuT7lyK3m4dcGg+zJ5kh+DcT31RDm9/G722XVnijBcCtA 7scA== X-Gm-Message-State: ANoB5pmX38Dj5MTsWYMIPEXgbLmL4lRUTmjP8FXXO5aZ+5urMYPcJWoO lcxH/gpgLtFRkWDVzCusHm/z61Yq446ghkjCwU2LNA== X-Google-Smtp-Source: AA0mqf7+mR5x25sBj43LTg4uwnKXH3/SDAlxwbcgb2oDbe7MUcFN3rlu/+9aKUPJF6baasbA8XKdSXvF73XwlJLW6CY= X-Received: by 2002:a81:7909:0:b0:36f:d2d9:cdc4 with SMTP id u9-20020a817909000000b0036fd2d9cdc4mr1434125ywc.380.1669039002452; Mon, 21 Nov 2022 05:56:42 -0800 (PST) MIME-Version: 1.0 References: <20220921001630.56765-1-konrad.dybcio@somainline.org> <83b90478-3974-28e6-cf13-35fc4f62e0db@marcan.st> <13b8c67c-399c-d1a6-4929-61aea27aa57d@somainline.org> <0e65a8b2-0827-af1e-602c-76d9450e3d11@marcan.st> <7fd077c5-83f8-02e2-03c1-900a47f05dc1@somainline.org> <20220922133056.eo26da4npkg6bpf2@bang-olufsen.dk> <87sfke32pc.fsf@kernel.org> <4592f87a-bb61-1c28-13f0-d041a6e7d3bf@linaro.org> In-Reply-To: <4592f87a-bb61-1c28-13f0-d041a6e7d3bf@linaro.org> From: Linus Walleij Date: Mon, 21 Nov 2022 14:56:31 +0100 Message-ID: Subject: Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi To: Konrad Dybcio Cc: Kalle Valo , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Hector Martin , "~postmarketos/upstreaming@lists.sr.ht" <~postmarketos/upstreaming@lists.sr.ht>, "martin.botka@somainline.org" , "angelogioacchino.delregno@somainline.org" , "marijn.suijten@somainline.org" , "jamipkettunen@somainline.org" , Arend van Spriel , Franky Lin , Hante Meuleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , "Zhao, Jiaqing" , "Russell King (Oracle)" , Soon Tak Lee , "linux-wireless@vger.kernel.org" , "brcm80211-dev-list.pdl@broadcom.com" , "SHA-cyfmac-dev-list@infineon.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 5:47 PM Konrad Dybcio wrote: > I can think of a couple of hacky ways to force use of 43596 fw, but I > don't think any would be really upstreamable.. If it is only known to affect the Sony Xperias mentioned then a thing such as: if (of_machine_is_compatible("sony,xyz") || of_machine_is_compatible("sony,zzz")... ) { // Enforce FW version } would be completely acceptable in my book. It hammers the problem from the top instead of trying to figure out itsy witsy details about firmware revisions. Yours, Linus Walleij