From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 705E6C7EE2F for ; Wed, 17 May 2023 21:12:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbjEQVMA (ORCPT ); Wed, 17 May 2023 17:12:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbjEQVL6 (ORCPT ); Wed, 17 May 2023 17:11:58 -0400 Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 595DB6A67 for ; Wed, 17 May 2023 14:11:56 -0700 (PDT) Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-559e53d1195so14608597b3.2 for ; Wed, 17 May 2023 14:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684357915; x=1686949915; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+ESbY04o8nMiMylkhFsmBCHORahVNqly1l+b0KOa640=; b=v5SexcE/rX2IDDr2Q+Jg71qCnOgAEyqh82pmkfwBGRhxmmH1TRMWr90nRSxjjoCF1r hGYuFJu1daRVqli8IXLNSBOXNnNwKzOdeANaee76IbW06Pf/BTOfIUH2zHOWfF/wUeLr c9kW4YK0gfMM5I4x7QJZ47n0t+18qK5ugWD6CJ4BotPw8/dhlvZv24u9ZNAgwO59exXX MWvs3Bh2AC8sMAG2Hx/UD7eVqmCETIqXr/Ve9A2Pb9L+Cr7EBH415lQBjobg5AAXwpbz Sd7PazZFNAZ/ItAcx6G3TlD/PshhlglA0pY56ts9Lx8xkxwMk/sofpb/+T6wZqAd4tS0 oXLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684357915; x=1686949915; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+ESbY04o8nMiMylkhFsmBCHORahVNqly1l+b0KOa640=; b=D73vj83S52y3j0TRCqC2of9kGbyReOoGdeAlmvFPfW0Y+onGuMAkMB4Yfz3YpzenEs omD2kQfC8KQ9Jxx7w38uciGXagtxqIxCGFgqWYEdmPdmdCoZI0QK6a4nNz3CRB0fG8hy hjFyKjvHGa8f/SD+DFh7uMjsJ5iVh//cLaBb5kaciczm0PjsOweaavDMUlInVBDTfoC/ byFw+88i1K+G23s/jNb5C/2EtsyDP0Vfu6OtycySQN88OGfUtuxlr5kUb2wLZEyBVVbh 7GkpriNiElaNygyxp0KtUUA1FnjUih9E4OhtJNviTjNvLd46elJ2e9jFDLjjS1Pw4pEe zbAg== X-Gm-Message-State: AC+VfDz4Eysv/kRY4KrsmvlsGHY5ni7CiT3B0HZ9Uiw5v2ygX8aYKCAZ YqbcD/sisbsHcS9K1loQY8TXaBkJtSeU0Ni6UZi01Q== X-Google-Smtp-Source: ACHHUZ4WiU/7XNv5tV812IdEVaHBoQ+14tMHeWf4rv+lcocaQlv66/13I8fR3QBFOtF5w7UHYni2NBlJ2CKlqIUUMBE= X-Received: by 2002:a0d:e84f:0:b0:55a:679f:1d90 with SMTP id r76-20020a0de84f000000b0055a679f1d90mr43201104ywe.2.1684357915574; Wed, 17 May 2023 14:11:55 -0700 (PDT) MIME-Version: 1.0 References: <20230430-nokia770-regression-v4-0-9b6dc5536b17@linaro.org> <20230430-nokia770-regression-v4-1-9b6dc5536b17@linaro.org> <20230517195911.GG271152@darkstar.musicnaut.iki.fi> In-Reply-To: <20230517195911.GG271152@darkstar.musicnaut.iki.fi> From: Linus Walleij Date: Wed, 17 May 2023 23:11:43 +0200 Message-ID: Subject: Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes To: Aaro Koskinen Cc: Janusz Krzysztofik , Tony Lindgren , Russell King , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Thomas Bogendoerfer , Dmitry Torokhov , Mark Brown , Bartosz Golaszewski , Andreas Kemnade , Helge Deller , Ulf Hansson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-input@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mmc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 17, 2023 at 9:59=E2=80=AFPM Aaro Koskinen wrote: > This does not compile as nokia770_ads7846_props is declared twice, > and nokia770_cbus_props and nokia770_mpuio_gpiochip_swnode are missing. Hmmmm I think we should probably update omap1_defconfig to enable all the OMAP1 drivers so we have good compile coverage. It's the ifdefs that fool me into believeing the code actually compiles ... > On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote: > > +static const struct software_node_ref_args nokia770_cbus_gpio_refs[] = =3D { > > + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 9, 0), > > + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 10, 0), > > + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 11, 0), > > +}; > > These should be nokia770_mpuio_gpiochip_node. Fixed it. > > +static const struct property_entry nokia770_ads7846_props[] =3D { > > + PROPERTY_ENTRY_REF_ARRAY("gpios", nokia770_cbus_gpio_refs), > > + { } > > }; > > This should be nokia770_cbus_props. Fixed it. Also enabled CONFIG_I2C_CBUS_GPIO and recompiled. Yours, Linus Walleij Yours, Linus Walleij