From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752429AbeD3JDa (ORCPT ); Mon, 30 Apr 2018 05:03:30 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:36552 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbeD3JD0 (ORCPT ); Mon, 30 Apr 2018 05:03:26 -0400 X-Google-Smtp-Source: AB8JxZpUwTD40m7+HQkJTtLRkDZGMmkBJB3BLJyOCAwQBDbPHo8kC+cHhfn5VIyaOhaD3o/+/ko7/uXQszv/gZ8lSf4= MIME-Version: 1.0 In-Reply-To: References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-11-wsa+renesas@sang-engineering.com> From: Linus Walleij Date: Mon, 30 Apr 2018 11:03:25 +0200 Message-ID: Subject: Re: [PATCH 10/61] gpio: simplify getting .drvdata To: Grygorii Strashko Cc: Wolfram Sang , "linux-kernel@vger.kernel.org" , Linux-Renesas , kernel-janitors@vger.kernel.org, Hoan Tran , Santosh Shilimkar , Kevin Hilman , Thierry Reding , Jonathan Hunter , Michal Simek , "open list:GPIO SUBSYSTEM" , Linux-OMAP , linux-tegra@vger.kernel.org, Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2018 at 5:14 PM, Grygorii Strashko wrote: > On 04/19/2018 09:05 AM, Wolfram Sang wrote: >> >> We should get drvdata from struct device directly. Going via >> platform_device is an unneeded step back and forth. >> >> Signed-off-by: Wolfram Sang >> --- >> >> Build tested only. buildbot is happy. Please apply individually. > > > for gpio-omap.c: > Reviewed-by: Grygorii Strashko Hm I only see the responses not the actual patch, I guess I will find it sooner or later. Wolfram: if I don't find it, poke me with something sharp so I get to apply it. Yours, Linus Walleij