From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E080C33CA2 for ; Sun, 12 Jan 2020 12:08:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32E68222D9 for ; Sun, 12 Jan 2020 12:08:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zdOsi9KQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732785AbgALMIK (ORCPT ); Sun, 12 Jan 2020 07:08:10 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:35236 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732694AbgALMIJ (ORCPT ); Sun, 12 Jan 2020 07:08:09 -0500 Received: by mail-lj1-f196.google.com with SMTP id j1so6938394lja.2 for ; Sun, 12 Jan 2020 04:08:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dpvAwF8ij5ixsdOGKkkuE/VXUPUlzWaJnocDXIvBfPY=; b=zdOsi9KQvxoeCvLRkX4N6k2Rlw/MryRYHauLiUfG+CPI0762MNGMQZf/B8ipKf1Gcb GFZMx8d8xkfHQb1JMAaPDUU3+2nGMKzFuS6w7FjoaU/NCHPZ+GZmM7ANTtHj9mzm+1H8 q9x12VUaz4AxtFJAUk27vwD2MihV1RwOpFS1hIRTihV1azvQeeH2vAbC46r/RRnhsuNL g2NfP1ImCzXQcn4XkGQuUjnr4VsObyaug1VZAqQNG8xpthgsg0SyjEBno1LlfdpLosH9 EB8+QZylnRZ7hzhZavMS6185sy7ABs1KObfiCwjtPnuBLerkdYGaAw9Gms5xPxtkD5MB UC7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dpvAwF8ij5ixsdOGKkkuE/VXUPUlzWaJnocDXIvBfPY=; b=WvGjqKJouMZybdct+vxTVYzKHYtUxbJOvx2Fat6mNBz/cIVwhedtF5qjrrcKHRzZn3 I1dZW/bVICwedzOai5brr/YDqe0QnUFBsJWHlAlp2RjvKa9epV4JNiGlEYR3eEI3akwY eaUMxGDVI9VFCrYBGjBAMS5nY7c5VFx1Lg7bPv7mtB6xBVb9rnGx7BfPwP0GOTT2/yeQ wcvh1P4h9/ilI34z9Md2qbLoUOd00AJYqx73df4lIEMFSpSJGWu9gWt3djrr8Bzib+9T pnuJYasWHgKY208FZpY57AuvFmp1+aY5UPXwDIjjDBw185oHuIDzWqdpQUpo6HQM72HJ 0n8A== X-Gm-Message-State: APjAAAViuErlGKwGINMy9Aj3JN3RMeNZTJMClUf5dTTlEaZUcePPE9q/ 4BX3RXiP5eFx5UXhLDR3HD2T2w7b7ny8HmvJW3yaNg== X-Google-Smtp-Source: APXvYqwZny2C/FIBKGxDbeJHV8CyKSMqhPtYMIYeGdOHwsz7zuDMm2sx1sA6URcYRatCxJmlCo3C48uygmVJg5exFXE= X-Received: by 2002:a05:651c:111c:: with SMTP id d28mr8195967ljo.32.1578830887594; Sun, 12 Jan 2020 04:08:07 -0800 (PST) MIME-Version: 1.0 References: <20191215174509.1847-1-linux@roeck-us.net> <20191215174509.1847-2-linux@roeck-us.net> <20200108153341.GB28530@roeck-us.net> <38af9fda-9edf-1b54-bd8d-92f712ae4cda@roeck-us.net> In-Reply-To: From: Linus Walleij Date: Sun, 12 Jan 2020 13:07:56 +0100 Message-ID: Subject: Re: [PATCH v2] hwmon: Driver for temperature sensors on SATA drives To: Gabriel C Cc: Guenter Roeck , "Martin K. Petersen" , linux-hwmon@vger.kernel.org, Jean Delvare , Bart Van Assche , Linux Doc Mailing List , LKML , linux-scsi , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , Chris Healy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 12, 2020 at 1:03 PM Gabriel C wrote: > Am So., 12. Jan. 2020 um 12:22 Uhr schrieb Linus Walleij > : > > > > On Sun, Jan 12, 2020 at 12:18 PM Gabriel C wrote= : > > > > > What I've noticed however is the nvme temperature low/high values on > > > the Sensors X are strange here. > > (...) > > > Sensor 1: +27.9=C2=B0C (low =3D -273.1=C2=B0C, high =3D +65261.= 8=C2=B0C) > > > Sensor 2: +29.9=C2=B0C (low =3D -273.1=C2=B0C, high =3D +65261.= 8=C2=B0C) > > (...) > > > Sensor 1: +23.9=C2=B0C (low =3D -273.1=C2=B0C, high =3D +65261.= 8=C2=B0C) > > > Sensor 2: +25.9=C2=B0C (low =3D -273.1=C2=B0C, high =3D +65261.= 8=C2=B0C) > > > > That doesn't look strange to me. It seems like reasonable defaults > > from the firmware if either it doesn't really log the min/max temperatu= res > > or hasn't been through a cycle of updating these yet. Just set both > > to absolute min/max temperatures possible. > > Ok I'll check that. > > Do you mean by setting the temperatures to use a lmsensors config? > Or is there a way to set these with a nvme command? Not that I know of. The min/max are the minumum and maximum temperatures the device has experienced during this power-on cycle. (If I understood things right!) If the device firmware doesn't log that, or the firmware hasn't ran through a log point, it makes sense to report absolute min/max of the scales. Yours, Linus Walleij