linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Shrirang Bagul <shrirang.bagul@canonical.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Denis CIOCCA <denis.ciocca@st.com>,
	Tiberiu Breana <tiberiu.a.breana@intel.com>,
	Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
	Gregor Boirie <gregor.boirie@parrot.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] iio: st_accel: Support sensor i2c probe using acpi
Date: Thu, 24 Nov 2016 15:26:51 +0100	[thread overview]
Message-ID: <CACRpkdazkanxGsQ6G=NrHc0duR46FLhA81BkZF4HpdxJECWHaw@mail.gmail.com> (raw)
In-Reply-To: <20161124053345.11254-3-shrirang.bagul@canonical.com>

On Thu, Nov 24, 2016 at 6:33 AM, Shrirang Bagul
<shrirang.bagul@canonical.com> wrote:

> Add support to probe st_accel sensors on i2c bus using ACPI. Compatible
> strings are not avaialable on ACPI based systems.
>
> Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
(...)

> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id st_accel_acpi_match[] = {
> +       {"SMO8A90", LNG2DM},
> +       { },
> +};

Why is ACPI only supporting one out of 14 devices?

Surely there are some out-of-tree ACPI platforms using one
or more of the others?

Apart from that it looks nice.

Yours,
Linus Walleij

  reply	other threads:[~2016-11-24 14:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24  5:33 [PATCH 0/3] iio: st_sensors: Support ACPI probe for st_sensors Shrirang Bagul
2016-11-24  5:33 ` [PATCH 1/3] iio: st_sensors: match sensors using ACPI handle Shrirang Bagul
2016-11-27 11:15   ` Jonathan Cameron
2016-11-24  5:33 ` [PATCH 2/3] iio: st_accel: Support sensor i2c probe using acpi Shrirang Bagul
2016-11-24 14:26   ` Linus Walleij [this message]
2016-11-27 11:14     ` Jonathan Cameron
2016-11-29  4:27       ` Shrirang Bagul
2016-11-24  5:33 ` [PATCH 3/3] iio: st_pressure: Support " Shrirang Bagul
2016-11-24 14:28   ` Linus Walleij
2016-11-27 11:12     ` Jonathan Cameron
2016-11-29  4:25       ` Shrirang Bagul
2016-11-30 13:04         ` Linus Walleij
2016-11-30 17:20         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdazkanxGsQ6G=NrHc0duR46FLhA81BkZF4HpdxJECWHaw@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=denis.ciocca@st.com \
    --cc=gregor.boirie@parrot.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.bianconi83@gmail.com \
    --cc=pmeerw@pmeerw.net \
    --cc=shrirang.bagul@canonical.com \
    --cc=tiberiu.a.breana@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).