From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753263AbdFPJ0N (ORCPT ); Fri, 16 Jun 2017 05:26:13 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:36715 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbdFPJ0K (ORCPT ); Fri, 16 Jun 2017 05:26:10 -0400 MIME-Version: 1.0 In-Reply-To: <2d71d93a22ed24c45b7ce7b52fa066cc0a14a69f.1497281623.git-series.gregory.clement@free-electrons.com> References: <2d71d93a22ed24c45b7ce7b52fa066cc0a14a69f.1497281623.git-series.gregory.clement@free-electrons.com> From: Linus Walleij Date: Fri, 16 Jun 2017 11:26:08 +0200 Message-ID: Subject: Re: [PATCH v3 6/9] pinctrl: mvebu: add driver for Armada CP110 pinctrl To: Gregory CLEMENT Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" , Rob Herring , "devicetree@vger.kernel.org" , Russell King , Nadav Haklai , Kostya Porotchkin , Neta Zur Hershkovits , Marcin Wojtas , Omri Itach , Shadi Ammouri , Hanna Hawa , Grzegorz Jaszczyk Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2017 at 5:34 PM, Gregory CLEMENT wrote: > From: Hanna Hawa > > This commit adds a pinctrl driver for the CP110 part of the Marvell > Armada 7K and 8K SoCs. The Armada 7K has a single CP110, where almost all > the MPP pins are available. On the other side, the Armada 8K has two > CP110, and the available MPPs are split between the master CP110 (MPPs 32 > to 62) and the slave CP110 (MPPs 0 to 31). > > The register interface to control the MPPs is however the same as all > other mvebu SoCs, so we can reuse the common pinctrl-mvebu.c logic. > > Signed-off-by: Hanna Hawa > Reviewed-by: Shadi Ammouri > > [updated for mvebu pinctrl and 4.9 changes: > - converted to simple_mmio > - converted to syscon/regmap > - removed unimplemented .remove function > - dropped DTS changes > - defered gpio ranges to DT > - fixed warning > - properly set soc->nmodes > -- rmk] > Signed-off-by: Russell King > > [ add missing MPP[61:56] function 14 (SDIO) > -- Konstantin Porotchkin] > Signed-off-by: Konstantin Porotchkin > > [ allow to properly register more then one instance of this driver > -- Grzegorz Jaszczyk] > Signed-off-by: Grzegorz Jaszczyk > > [ - rebased on 4.12-rc1 > - fixed the 80 character limit for mvebu_mpp_mode array > - aligned the compatible name on the ones already used > - fixed the MPP table for CP110: some MPP are not available on Armada 7K > -- Gregory CLEMENT] > Signed-off-by: Gregory CLEMENT > > Tested-by: Thomas Petazzoni Patch applied. Yours, Linus Walleij