From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755174AbcKVIrY (ORCPT ); Tue, 22 Nov 2016 03:47:24 -0500 Received: from mail-qk0-f179.google.com ([209.85.220.179]:32973 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbcKVIrX (ORCPT ); Tue, 22 Nov 2016 03:47:23 -0500 MIME-Version: 1.0 In-Reply-To: <20161116152047.3336967-1-arnd@arndb.de> References: <20161116152047.3336967-1-arnd@arndb.de> From: Linus Walleij Date: Tue, 22 Nov 2016 09:47:20 +0100 Message-ID: Subject: Re: [PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation To: Arnd Bergmann Cc: Daniel Lezcano , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 16, 2016 at 4:20 PM, Arnd Bergmann wrote: > This function clearly never worked and always returns true, > as pointed out by gcc-7: > > arch/arm/mach-ux500/pm.c: In function 'prcmu_is_cpu_in_wfi': > arch/arm/mach-ux500/pm.c:137:212: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context] > > With the added braces, the condition actually makes sense. > > Fixes: 34fe6f107eab ("mfd : Check if the other db8500 core is in WFI") > Signed-off-by: Arnd Bergmann Acked-by: Linus Walleij Will you apply it directly to ARM SoC or should I queue it and send it with a pull request? Yours, Linus Walleij