From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753827AbcFPHUT (ORCPT ); Thu, 16 Jun 2016 03:20:19 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:35228 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbcFPHUQ (ORCPT ); Thu, 16 Jun 2016 03:20:16 -0400 MIME-Version: 1.0 In-Reply-To: <20160616002024.GO28218@codeaurora.org> References: <1465945346-29298-1-git-send-email-linus.walleij@linaro.org> <20160616002024.GO28218@codeaurora.org> From: Linus Walleij Date: Thu, 16 Jun 2016 09:20:15 +0200 Message-ID: Subject: Re: [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660 To: Stephen Boyd Cc: Lee Jones , "linux-kernel@vger.kernel.org" , Bjorn Andersson , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2016 at 2:20 AM, Stephen Boyd wrote: > On 06/15, Linus Walleij wrote: >> @@ -426,10 +447,11 @@ static irqreturn_t qcom_rpm_ack_interrupt(int irq, void *dev) >> u32 ack; >> int i; >> >> - ack = readl_relaxed(RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT)); >> - for (i = 0; i < RPM_SELECT_SIZE; i++) >> - writel_relaxed(0, RPM_CTRL_REG(rpm, RPM_ACK_SELECTOR + i)); >> - writel(0, RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT)); >> + ack = readl_relaxed(RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off)); >> + for (i = 0; i < rpm->data->sel_size; i++) >> + writel_relaxed(0, >> + RPM_CTRL_REG(rpm, rpm->data->ack_sel_off + i)); >> + writel(0, RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off)); > > Does the ack size vary though? I thought that was always 7. It > seems that really only the request selector size varies? Ah you're right, I'll send a patch on top of this one fixing it up. Yours, Linus Walleij