From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2CADC352A3 for ; Mon, 10 Feb 2020 12:13:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 886642082F for ; Mon, 10 Feb 2020 12:13:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YIBsA5VJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727628AbgBJMNh (ORCPT ); Mon, 10 Feb 2020 07:13:37 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:37796 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727522AbgBJMNg (ORCPT ); Mon, 10 Feb 2020 07:13:36 -0500 Received: by mail-lj1-f194.google.com with SMTP id v17so6865554ljg.4 for ; Mon, 10 Feb 2020 04:13:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vN2cr2vYuekIm6JB3RgzI3N00DPK13rxE05UgfLMK1g=; b=YIBsA5VJek4eTnKn2pyI8v0xnHMc6C4Me1qGENSJaftZsVsADcpc7zQdgAcvstNpGI 5uUV001BlBaybQA8GmgHoJRqBxxM5Lq5CyNCKgSrOzLzaC414i3TG5gAYLt+8gc4q/5G rsoeEPAQcQL8WP6F5zUiR722OFbq6TNOkeoAyIfgowZ/o9t4weJ/jtY0nAdAYSM8mlG5 PECJAaVQqb8k39iwk77F+1E6Jwh7tqDIzlLNToxNuoiaN0m8pDpC8mUfCGgCLxr3ZHDd jEUB4tk2OlInOczT/HDeua+aqxGkJUWFpjji73fqdMH8VPQ91nMkt+nZRLmdaJeynLuf zaog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vN2cr2vYuekIm6JB3RgzI3N00DPK13rxE05UgfLMK1g=; b=atCqZ3AWpsxyhQDUzaSfQIK80jTnLnO7gNTDz5Ckirx7rw70UgBdBM0eykGwJnMDd/ DSvORjsjYzmUHmVibg/D0Ql9uQzllcyb9qd8GU5pceEIlG5WVT1KyAaak/kXLOzA78F6 dU/4x/eaWtb7SAmbtjxFuFgqEhB6pFdjYJ32KMXat1ALb2dc1l/dsAhR+tvCFVhnDCxM RTC9dkDsVg+eIutL5YRWhDmFyCx9tdbZ3fEgxq8/5Unv0jkdpDrne0OYYz1PPRWoUJVK CmD2bCU2WE9VkgSloiZVE90duBdWwvM0JTAx1pUJ7x7WONFsN+U4WoH/qEOJyR3T/wap UzbQ== X-Gm-Message-State: APjAAAUNaM01oC+xb1obR+aTXIppuhKKEMJuacHQLwq1+aSC0Pnwh+tH lCqe4P8FE9fkrtMJtE6cbi3xeuFiNEDGCWOuvQnS2w== X-Google-Smtp-Source: APXvYqyqMjSOxKkLTzhlykvdu5X6v3ck2AqaYe6S9rhtmxvr4OjpPMMK1+q4Qeb5isYmKKI7mE7VWDk2kpFAgXhCU18= X-Received: by 2002:a2e:9013:: with SMTP id h19mr756323ljg.223.1581336814637; Mon, 10 Feb 2020 04:13:34 -0800 (PST) MIME-Version: 1.0 References: <20200205194804.1647-1-mst@semihalf.com> <20200206083149.GK2667@lahna.fi.intel.com> <20200207075654.GB2667@lahna.fi.intel.com> In-Reply-To: From: Linus Walleij Date: Mon, 10 Feb 2020 13:13:23 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: cherryview: Add quirk with custom translation of ACPI GPIO numbers To: =?UTF-8?Q?Micha=C5=82_Stanek?= Cc: Mika Westerberg , "open list:GPIO SUBSYSTEM" , ACPI Devel Maling List , "linux-kernel@vger.kernel.org" , stanekm@google.com, stable , Marcin Wojtas , levinale@chromium.org, Andy Shevchenko , Bartosz Golaszewski , "Rafael J. Wysocki" , Dmitry Torokhov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 8, 2020 at 7:43 PM Micha=C5=82 Stanek wrote: > Actually it is a GPIO offset in ACPI tables for Braswell that was > hardcoded in the old firmware to match the previous (consecutive) > Linux GPIO numbering. That's bad practice by the firmware authors. (Sad face) We have enough problem saving ourselves from our own legacy ABIs without someone handling out more guns to shoot oneself in the foot with. :( I'm also speaking on behalf of Microsoft and others in this I think. In the past we would find Windowsisms in the BIOSes and get really annoyed that we had to work around them. Now there are Linuxisms in the BIOS, that's not any better. Yours, Linus Walleij