From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752427AbcD2JNc (ORCPT ); Fri, 29 Apr 2016 05:13:32 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:35468 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbcD2JNa (ORCPT ); Fri, 29 Apr 2016 05:13:30 -0400 MIME-Version: 1.0 In-Reply-To: <1461067821-2031706-1-git-send-email-arnd@arndb.de> References: <1461067821-2031706-1-git-send-email-arnd@arndb.de> Date: Fri, 29 Apr 2016 11:13:29 +0200 Message-ID: Subject: Re: [PATCH] gpio/qoriq: select IRQ_DOMAIN From: Linus Walleij To: Arnd Bergmann Cc: Liu Gang , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 19, 2016 at 2:10 PM, Arnd Bergmann wrote: > The gpio-mpc8xxx driver requires IRQ domains but can be built > without them, resulting on a failure to build certain randconfigs > on ARM: > > drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_to_irq': > drivers/gpio/gpio-mpc8xxx.c:92:10: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration] > return irq_create_mapping(mpc8xxx_gc->irq, offset); > > This selects IRQ_DOMAIN from the driver to ensure we can build it. > > Signed-off-by: Arnd Bergmann > Fixes: 5df7fd46b70b ("gpio/qoriq: Add qoriq platforms support") Patch applied. Yours, Linus Walleij