From: Linus Walleij <linus.walleij@linaro.org>
To: Mauri Sandberg <maukka@ext.kapsi.fi>
Cc: Mauri Sandberg <sandberg@mailfence.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Drew Fustini <drew@beagleboard.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: gpio-mux-input: add documentation
Date: Tue, 1 Jun 2021 12:10:47 +0200 [thread overview]
Message-ID: <CACRpkdbD-AZrZrHZ0mQm09TV6mMWunmBF1sMLgaDFUHxTV+R5Q@mail.gmail.com> (raw)
In-Reply-To: <20210530161333.3996-2-maukka@ext.kapsi.fi>
On Sun, May 30, 2021 at 6:16 PM Mauri Sandberg <maukka@ext.kapsi.fi> wrote:
> Add documentation for a general GPIO multiplexer.
>
> Signed-off-by: Mauri Sandberg <maukka@ext.kapsi.fi>
> Tested-by: Drew Fustini <drew@beagleboard.org>
> Reviewed-by: Drew Fustini <drew@beagleboard.org>
Overall very interesting!
> + pin-gpios:
> + description: |
> + The GPIO pin used as the output from the multiplexer
This is not a good name. "pin" what pin? Choose a descriptive
name, like:
parent-gpios
multiplexed-gpios
cascaded-gpios
fanout-gpios
(My order of preference.)
Otherwise these bindings look good.
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-06-01 10:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210325122832.119147-1-sandberg@mailfence.com>
2021-05-30 16:13 ` [PATCH v4 0/2] gpio: add generic gpio input multiplexer Mauri Sandberg
2021-05-30 16:13 ` [PATCH v4 1/2] dt-bindings: gpio-mux-input: add documentation Mauri Sandberg
2021-06-01 10:10 ` Linus Walleij [this message]
2021-06-01 10:44 ` Linus Walleij
2021-06-02 9:31 ` Mauri Sandberg
2021-06-02 10:35 ` Linus Walleij
2021-06-02 11:21 ` Mauri Sandberg
2021-06-04 7:51 ` Linus Walleij
2021-06-01 13:32 ` Rob Herring
2021-06-02 11:36 ` Mauri Sandberg
2021-05-30 16:13 ` [PATCH v4 2/2] gpio: gpio-mux-input: add generic gpio input multiplexer Mauri Sandberg
2021-05-30 18:09 ` Andy Shevchenko
2021-05-30 19:02 ` Mauri Sandberg
2021-05-30 19:38 ` Andy Shevchenko
2021-05-31 10:19 ` Mauri Sandberg
2021-06-01 10:38 ` Linus Walleij
2021-06-21 17:20 ` [PATCH v5 0/2] gpio: add generic gpio cascade Mauri Sandberg
2021-06-21 17:20 ` [PATCH v5 1/2] dt-bindings: gpio-cascade: add documentation Mauri Sandberg
2021-06-24 18:30 ` Rob Herring
2021-06-21 17:20 ` [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade Mauri Sandberg
2021-06-21 17:43 ` Andy Shevchenko
2021-06-21 18:31 ` Enrico Weigelt, metux IT consult
2021-10-15 12:56 ` Mauri Sandberg
2021-10-15 17:20 ` Andy Shevchenko
2021-10-19 12:57 ` [PATCH v6 0/2] " Mauri Sandberg
2021-10-19 12:57 ` [PATCH v6 1/2] dt-bindings: gpio-cascade: add documentation Mauri Sandberg
2021-10-19 12:57 ` [PATCH v6 2/2] gpio: gpio-cascade: add generic GPIO cascade Mauri Sandberg
2021-10-19 13:12 ` Andy Shevchenko
2021-10-19 20:08 ` [PATCH v7 0/2] " Mauri Sandberg
2021-10-19 20:08 ` [PATCH v7 1/2] dt-bindings: gpio-cascade: add documentation Mauri Sandberg
2021-10-24 22:18 ` Linus Walleij
2021-10-19 20:08 ` [PATCH v7 2/2] gpio: gpio-cascade: add generic GPIO cascade Mauri Sandberg
2021-10-24 22:17 ` Linus Walleij
2021-10-25 9:29 ` Andy Shevchenko
2021-10-26 19:15 ` [PATCH v8 0/2] " Mauri Sandberg
2021-10-26 19:15 ` [PATCH v8 1/2] dt-bindings: gpio-cascade: add documentation Mauri Sandberg
2021-10-26 19:15 ` [PATCH v8 2/2] gpio: gpio-cascade: add generic GPIO cascade Mauri Sandberg
2022-02-05 21:59 ` [RESEND v8 0/2] " Mauri Sandberg
2022-02-05 21:59 ` [RESEND v8 1/2] dt-bindings: gpio-cascade: add documentation Mauri Sandberg
2022-02-05 21:59 ` [RESEND v8 2/2] gpio: gpio-cascade: add generic GPIO cascade Mauri Sandberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbD-AZrZrHZ0mQm09TV6mMWunmBF1sMLgaDFUHxTV+R5Q@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=geert+renesas@glider.be \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maukka@ext.kapsi.fi \
--cc=robh+dt@kernel.org \
--cc=sandberg@mailfence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).