From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C25CC32751 for ; Sat, 10 Aug 2019 08:13:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 208D8208C3 for ; Sat, 10 Aug 2019 08:13:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VnJxbftI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbfHJINM (ORCPT ); Sat, 10 Aug 2019 04:13:12 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:43745 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbfHJINM (ORCPT ); Sat, 10 Aug 2019 04:13:12 -0400 Received: by mail-lj1-f194.google.com with SMTP id h15so452989ljg.10 for ; Sat, 10 Aug 2019 01:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oqsU2heLXHHBs96Q5jI1j5tMoKsUDIBVmfyGumKZ6LM=; b=VnJxbftIzPrqH4FoIz+w63T9HvLAwPyuIAzFqmtEtWAsLj/01rK86PGFGuGpSqWYv+ EOc3pJBX5N72NrROGYfkzRIEBM/NZHAtlunaj25jmAa22WMIK6W8WaeA6NQrcRQ890ve gTKEzqoNeorIPkcAkbULvIA82MectHdfWgQVc2tti+zAedXKseEDZCsXl4IK+jsWOZyk R7BDcza0vJn1D+S49B4cTvaTLZpzO5Zji8UHdpqukz0sSpuhB6HNFG8n8zxgS0EkyZrb 5PC++TGzLIxcQd3/xU9h8T2WbaloLuBlyrUH/bwdms17HdBtBey1e6TEAlNNF3mOqFH5 GZ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oqsU2heLXHHBs96Q5jI1j5tMoKsUDIBVmfyGumKZ6LM=; b=kYrbgK5Xk5EEYNSx2wRBBDmf1jcl95t5pUZnWyz81+zPYGnQsuQQiKkz62TTAXOdHX GjjY+OX465dvJIYnP23eCLu8mV9C+W/GeNz8OH1Bo4rk6QGr6o2/aumyz4k/LPBiOD+g aPiGFAwroYRAr9uNfOZ4TkU6nhicm7QXwWURGq5ZV+l+nOVat3eLX39M5ZrkYEwPuDIX KERa/iWxJ9YPa4B32+g0GABMTIPoqLRP07/xsf9O+ME7LM5ZsXcubh2ujb1MSF/U8gfo BaxS1gmUhx41DtjvjzuiO1es+EGHZyvSFuA2uwrTmyYhhTXul24pIw6BN5BMVth2qO8i 4urQ== X-Gm-Message-State: APjAAAXgikboysAkh+wxATyCBjb0PihIkwBn74DHf3d/tGLcuHzvwbgq Y3UiGIKGyMt6bJQifYcfb37yx2Ojqwvx2/rZk8LBaQ== X-Google-Smtp-Source: APXvYqw5IJDtu+KvWNV5b+0f7BnCDMIkmE9siMLHoOIDt6M7/m7Z1qUizRn9O0DLYl+XLv2UlhKWmwCr8OjDx7Cm5k0= X-Received: by 2002:a2e:8756:: with SMTP id q22mr13818205ljj.108.1565424790000; Sat, 10 Aug 2019 01:13:10 -0700 (PDT) MIME-Version: 1.0 References: <20190807003037.48457-1-natechancellor@gmail.com> In-Reply-To: <20190807003037.48457-1-natechancellor@gmail.com> From: Linus Walleij Date: Sat, 10 Aug 2019 10:12:57 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: aspeed: g6: Remove const specifier from aspeed_g6_sig_expr_set's ctx parameter To: Nathan Chancellor Cc: Andrew Jeffery , Joel Stanley , linux-aspeed , OpenBMC Maillist , "open list:GPIO SUBSYSTEM" , Linux ARM , "linux-kernel@vger.kernel.org" , clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 7, 2019 at 2:32 AM Nathan Chancellor wrote: > clang errors: > > drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c:2325:9: error: incompatible > pointer types initializing 'int (*)(struct aspeed_pinmux_data *, const > struct aspeed_sig_expr *, bool)' with an expression of type 'int (const > struct aspeed_pinmux_data *, const struct aspeed_sig_expr *, bool)' > [-Werror,-Wincompatible-pointer-types] > .set = aspeed_g6_sig_expr_set, > ^~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > Commit 674fa8daa8c9 ("pinctrl: aspeed-g5: Delay acquisition of regmaps") > changed the set function pointer declaration and the g6 one wasn't > updated (I assume because it wasn't merged yet). > > Fixes: 2eda1cdec49f ("pinctrl: aspeed: Add AST2600 pinmux support") > Link: https://github.com/ClangBuiltLinux/linux/issues/632 > Signed-off-by: Nathan Chancellor Patch applied with Andrew's ACK. Yours, Linus Walleij