From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F10C0650F for ; Mon, 5 Aug 2019 11:26:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D41D20856 for ; Mon, 5 Aug 2019 11:26:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qIT1QTF1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728421AbfHEL0k (ORCPT ); Mon, 5 Aug 2019 07:26:40 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:37958 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727158AbfHEL0j (ORCPT ); Mon, 5 Aug 2019 07:26:39 -0400 Received: by mail-lj1-f193.google.com with SMTP id r9so78983641ljg.5 for ; Mon, 05 Aug 2019 04:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jIRa3TvqiJWaXbGz1Sxgf45N57AQXqRegz7cACuc68A=; b=qIT1QTF1w0efi6+3yipuwFrYZL30qqHrYgmctXv8UnneOjx2GgF+0JZtmxWgB1Mg8/ v+7dHYiNP7xfVA03cjMy3k9BEgBXLsYVymjoWiHzr3/5VNRBifxMEd4ZWVsXOKaAmTrB CcSQROuJEp6EE32Z1GgjQVsmuRDRbtCDceXuYg38GWcy27+AnKpv+kH4QLXoTIvYUobH dGpTPrusQ7v5U3BtBFHERMkYU90cXbkQJxsIMDQup9UDjnWGH5+uV4f6ygLlQHWhCnGm rMuIko9zudS/9WkGNeZXicg8j4Tw5FD2bvF67egZMkd3SiZN3d2Veb/HAxmtWny9+eXo O75Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jIRa3TvqiJWaXbGz1Sxgf45N57AQXqRegz7cACuc68A=; b=qDVq3nlx/8OZAxLPb5cWcvUXSo/NJwob8p/AIejmCqyxTgw9RhAVHtXHjWloS2vJ8X WbB2DTcR131kZf3M2bkHv8pZkTPKeyTqzRrCkt+yXXIK2NlGxPXVWkI9iMgRMiYlZNXZ cSMSpOnyIqCqacMcdI/OJsTqHSu3alVJxboj8ggwf4yHxLFekn/oSK0LUUibug1EbTBQ x5pfYO30IT337hjqmUNcn9tmW4iHSNMUNMHVzyXykHyGugpu8XkHq8XyPMgL6CE8mRkY iAtamYPXdMs163Ji/2IWldYBS/wbdJGBt3I8WcreBMC2j2XqatewQCQRB9imyiUKe6yk 9hSw== X-Gm-Message-State: APjAAAXgNJBKk3wCmvBqeRHHbYtibfdtjDhV3vEsfqEhSwUKnvlEWnZ5 D+PNfUqnLBwVaRr1kIk2Cazzjkd9hGS7RozRWzdgpw== X-Google-Smtp-Source: APXvYqwwzZUZzBlGj7UKPIgPKL/x6U8mlX5D2rx/vEhK1wdbSnO0UQNpPepk9N43zQqnbiwujFLC3RSHRZ8fPZyvLzM= X-Received: by 2002:a2e:9048:: with SMTP id n8mr62373ljg.37.1565004397519; Mon, 05 Aug 2019 04:26:37 -0700 (PDT) MIME-Version: 1.0 References: <20190730181557.90391-1-swboyd@chromium.org> <20190730181557.90391-16-swboyd@chromium.org> In-Reply-To: <20190730181557.90391-16-swboyd@chromium.org> From: Linus Walleij Date: Mon, 5 Aug 2019 13:26:25 +0200 Message-ID: Subject: Re: [PATCH v6 15/57] gpio: Remove dev_err() usage after platform_get_irq() To: Stephen Boyd Cc: "linux-kernel@vger.kernel.org" , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 8:16 PM Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. (...) > While we're here, remove braces on if statements that only have one > statement (manually). > > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: linux-gpio@vger.kernel.org > Cc: Greg Kroah-Hartman > Signed-off-by: Stephen Boyd Patch applied! Yours, Linus Walleij