From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E92DC63707 for ; Tue, 6 Dec 2022 23:38:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbiLFXiQ (ORCPT ); Tue, 6 Dec 2022 18:38:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbiLFXiL (ORCPT ); Tue, 6 Dec 2022 18:38:11 -0500 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 881C845A11 for ; Tue, 6 Dec 2022 15:38:10 -0800 (PST) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-3c090251d59so169393037b3.4 for ; Tue, 06 Dec 2022 15:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iMeYuP/IHBLdEkldut+tJt83tnk8BcGmkM9CbSyHlFA=; b=r33OvNK2vouj/RUCapruSqB5z+SEWuKjo/v0FtdmTHNEiB1bhsl3LKwcWGxRLJxfQv QDXi9cX4aQk4XRdSOH/7iUu6Bl+b+eitsw2i3ooxmBigZvONyt8BVpbrLTdYkK+ATc0/ kcdJD16MIbGQE1nJImcppwey7pxm/r1Ny2ZVFC+55SIiRPwqaD+aaGGyGtI6Ll1ztqX7 XDAJKRp8iEyQfKuo9unh2ZHFeGRmEmGTfb+b7/FE/wPkNIDHNxovfvHeLPRjyAN0oSrE 54rZpWflr8ixj07RdC+xedXQQjcSr9g41aWmZOBQXaw9cE/jK/klIvYe4Q9+KQNwAyMP C7CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iMeYuP/IHBLdEkldut+tJt83tnk8BcGmkM9CbSyHlFA=; b=zaOqXXoUUI0+REjDNDyejJV7umwCE2GKj59LdRQYkt3qSFAk2g0YnMiHAA2v7PXfDZ deCrGVE6CQZ3cFayl8XuFvJ2vnUh39S+dWOp2UznP5Ji+oHpljhF0BOD+EHq64nYRKUw 8MVjXdysAo1i93PiT5ekKxmgm+Dg3nfmnO0ESQC2/SYC7ax6ugj+NkR2nk0LPcvpRm6T bU6wKKJ0F5flQyf6O48D2o5BsqLfAOId3g6GGQ07ez7gC7qp41y14kM04bueMrvGW1w6 XmT4W1pS4f/oIXUJxLzUfu98TVHXRAtrMwDRYKsUTsnEeutKP8gSwSlXBFxZDfv5Da5l Bilg== X-Gm-Message-State: ANoB5plyKmGauDBEz2xbFGwbEysY1KFloFvXDueP1r6R2fNyIXenbsmz LxC5yUM6t4x/OL0Ay7z/9sguWrZBWpDZYttkTm9j1A== X-Google-Smtp-Source: AA0mqf4GTH7r4BUD6E/vaD6DN9DWu08A2GD9X5LPfQeXKoAkdHS4YGuN+yaVSSkQbETQkqd4MnVh0mCw8oLrPP71MPQ= X-Received: by 2002:a81:798f:0:b0:37a:e8f:3cd3 with SMTP id u137-20020a81798f000000b0037a0e8f3cd3mr19373621ywc.187.1670369889710; Tue, 06 Dec 2022 15:38:09 -0800 (PST) MIME-Version: 1.0 References: <20220921001630.56765-1-konrad.dybcio@somainline.org> <13b8c67c-399c-d1a6-4929-61aea27aa57d@somainline.org> <0e65a8b2-0827-af1e-602c-76d9450e3d11@marcan.st> <7fd077c5-83f8-02e2-03c1-900a47f05dc1@somainline.org> <20220922133056.eo26da4npkg6bpf2@bang-olufsen.dk> <87sfke32pc.fsf@kernel.org> <4592f87a-bb61-1c28-13f0-d041a6e7d3bf@linaro.org> <87fse76yig.fsf@kernel.org> <87bkov6x1q.fsf@kernel.org> <28991d2d-d917-af47-4f5f-4e8183569bb1@linaro.org> <6e4f1795-08b5-7644-d1fa-102d6d6b47fb@linaro.org> <62566987-6bd2-eed3-7c2f-ec13c5d34d1b@gmail.com> <21fc5c0e-f880-7a14-7007-2d28d5e66c7d@linaro.org> In-Reply-To: <21fc5c0e-f880-7a14-7007-2d28d5e66c7d@linaro.org> From: Linus Walleij Date: Wed, 7 Dec 2022 00:37:57 +0100 Message-ID: Subject: Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi To: Konrad Dybcio , Arend van Spriel , Arend Van Spriel Cc: Kalle Valo , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Hector Martin , "martin.botka@somainline.org" , "angelogioacchino.delregno@somainline.org" , "marijn.suijten@somainline.org" , "jamipkettunen@somainline.org" , Franky Lin , Hante Meuleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , "Zhao, Jiaqing" , "Russell King (Oracle)" , "linux-wireless@vger.kernel.org" , "brcm80211-dev-list.pdl@broadcom.com" , "SHA-cyfmac-dev-list@infineon.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Krzysztof Kozlowski , Rob Herring , phone-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 6, 2022 at 10:59 AM Konrad Dybcio wrote: > Yes, it does seem to work just fine! The kernel now looks for > brcm/brcmfmac4359c-pcie.sony,kagura-row.bin as we would expect. So the Sony kagura needs a special brcmfmac firmware like so many other mobile phones. There are a few Samsungs with custom firmware as well. Arend: what is the legal situation with these custom firmwares? I was under the impression that Broadcom actually made these, so they could in theory be given permission for redistribution in linux-firmware? Some that I have are newer versions than what is in Linux-firmware, e.g this from linux-firmware: brcm/brcmfmac4330-sdio.bin 4330b2-roml/sdio-ag-pool-ccx-btamp-p2p-idsup-idauth-proptxstatus-pno-aoe-toe-pktfilter-keepalive Version: 5.90.125.104 CRC: 2570e6a3 Date: Tue 2011-10-25 19:34:26 PDT There is this found in Samsung Codina GT-I8160: 4330b2-roml/sdio-g-p2p-aoe-pktfilter-keepalive-pno-ccx-wepso Version: 5.99.10.0 CRC: 4f7fccf Date: Wed 2012-12-05 01:02:50 PST FWID 01-52653ba9 Or: brcmfmac4334-sdio.bin 4334b1min-roml/sdio-ag-pno-p2p-ccx-extsup-proptxstatus-dmatxrc-rxov-pktfilter-keepalive-aoe-vsdb-wapi-wl11d Version: 6.10.0.0 CRC: 31410dd4 Date: Tue 2012-06-26 11:33:07 PDT FWID 01-8ee3be86 There is this found in Samsung Golden GT-I8190N: 4334b1-roml/sdio-ag-p2p-extsup-aoe-pktfilter-keepalive-pno-dmatxrc-rxov-proptxstatus-vsdb-mchan-okc-rcc-fmc-wepso-txpwr-autoabn-sr Version: 6.10.58.99 CRC: 828f9174 Date: Mon 2013-08-26 02:13:44 PDT FWID 01-e39d4d77 So in some cases more than a year newer firmware versions compared to linux-firmware, I guess also customized for the phones, but I can't really tell because we don't have anything of similar date in linux-firmware. Yours, Linus Walleij