From: Linus Walleij <linus.walleij@linaro.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Timur Tabi <timur@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: Fix gpio_direction_* for single direction GPIOs
Date: Tue, 25 Sep 2018 09:36:14 +0200 [thread overview]
Message-ID: <CACRpkdbOUgvrC7GduKj2fOo6kn1HdtODvQ22NVnxw4pV6uivhA@mail.gmail.com> (raw)
In-Reply-To: <20180921103604.13361-1-ricardo.ribalda@gmail.com>
Hi Ricardo,
thanks for the patch and sorry for taking time before responding.
On Fri, Sep 21, 2018 at 12:36 PM Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> GPIOs with no programmable direction are not required to implement
> direction_output nor direction_input.
>
> If we try to set an output direction on an output-only GPIO or input
> direction on an input-only GPIO simply return 0.
>
> This allows this single direction GPIO to be used by libgpiod.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
It makes perfect sense, patch applied.
I'll go in and add some comments to the code so I understand it
right as well in the future.
Yours,
Linus Walleij
prev parent reply other threads:[~2018-09-25 7:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 10:36 [PATCH] gpiolib: Fix gpio_direction_* for single direction GPIOs Ricardo Ribalda Delgado
2018-09-21 10:36 ` [PATCH v2] gpiolib: Show correct direction from the beginning Ricardo Ribalda Delgado
2018-09-21 12:25 ` Timur Tabi
2018-09-27 6:51 ` Stephen Boyd
2018-09-27 12:19 ` Timur Tabi
2018-09-27 14:04 ` Jeffrey Hugo
2018-09-27 14:19 ` Timur Tabi
2018-09-27 14:34 ` Jeffrey Hugo
2018-09-28 19:14 ` Jeffrey Hugo
2018-09-28 19:22 ` Timur Tabi
2018-09-29 6:23 ` Ricardo Ribalda Delgado
2018-09-29 13:21 ` Timur Tabi
2018-09-29 13:25 ` Timur Tabi
[not found] ` <D3E6F4C4-E1C4-4D88-B118-878576BF5281@gmail.com>
2018-10-01 11:54 ` Linus Walleij
2018-10-01 13:36 ` Ricardo Ribalda Delgado
2018-10-01 14:27 ` Jeffrey Hugo
2018-10-01 21:20 ` Linus Walleij
2018-10-02 7:15 ` Ricardo Ribalda Delgado
2018-10-02 7:38 ` Linus Walleij
2018-10-02 12:26 ` Timur Tabi
2018-10-02 12:51 ` Linus Walleij
2018-09-25 7:36 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbOUgvrC7GduKj2fOo6kn1HdtODvQ22NVnxw4pV6uivhA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=swboyd@chromium.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).