From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbaE0N1l (ORCPT ); Tue, 27 May 2014 09:27:41 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:58843 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbaE0N1g (ORCPT ); Tue, 27 May 2014 09:27:36 -0400 MIME-Version: 1.0 In-Reply-To: References: <1398287792-19831-1-git-send-email-linus.walleij@linaro.org> <1398287792-19831-2-git-send-email-linus.walleij@linaro.org> Date: Tue, 27 May 2014 15:27:36 +0200 Message-ID: Subject: Re: [PATCH 1/2] RFT: pinctrl: sirf: switch to using allocated state container From: Linus Walleij To: Barry Song Cc: LKML , Barry Song , Linux GPIO List , DL-SHA-WorkGroupLinux Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 25, 2014 at 10:26 AM, Barry Song wrote: > 2014-05-09 19:53 GMT+08:00 Linus Walleij : >> On Thu, May 1, 2014 at 2:29 PM, Barry Song wrote: >>> 2014-04-24 5:16 GMT+08:00 Linus Walleij : >> >>>> This rewrites the SIRF pinctrl driver to allocate a state container >>>> for the GPIO chip, just as is done for the pin controller, and >>>> use the gpiochip_add_pin_range() to add the range from the gpiochip >>>> side rather than adding the range from the pinctrl side. >>>> >>>> All resulting changes are done in order to pass around a state >>>> container rather than refer to a static global object. >>>> >>>> Signed-off-by: Linus Walleij >>> >>> Linus, thanks! but this breaks prima2 pinctrl subsystem, do you have an idea? >>> otherwise i will do a debug to find the reason. >> >> Unfortunately no :-( >> >> This is the downside of dry-coding ... I rely on others to help out. >> >> See it as a suggestion to what I think should be refactored and how, >> I'll keep it on a branch as some "TODO" item for the moment. >> > > after moving pinctrl name from sirfsoc-gpio* to dev_name(&pdev->dev) as below: > - err = gpiochip_add_pin_range(&sgpio->chip.gc, "sirfsoc-gpio*", > + err = gpiochip_add_pin_range(&sgpio->chip.gc, dev_name(&pdev->dev), > > Acked-by: Barry Song Does this mean it works with that change so it's a Tested-by? I don't want to apply it if something breaks... Yours, Linus Walleij