From: Linus Walleij <linus.walleij@linaro.org>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: at91-pio4: Fix slew rate disablement
Date: Sat, 10 Apr 2021 02:08:39 +0200 [thread overview]
Message-ID: <CACRpkdbRfnZT9OU3FccZ7vny+Ami=k+dkDr4Lo7w_JOgzotX9A@mail.gmail.com> (raw)
In-Reply-To: <20210409082522.625168-1-tudor.ambarus@microchip.com>
On Fri, Apr 9, 2021 at 10:25 AM Tudor Ambarus
<tudor.ambarus@microchip.com> wrote:
> The slew rate was enabled by default for each configuration of the
> pin. In case the pin had more than one configuration, even if
> we set the slew rate as disabled in the device tree, the next pin
> configuration would set again the slew rate enabled by default,
> overwriting the slew rate disablement.
> Instead of enabling the slew rate by default for each pin configuration,
> enable the slew rate by default just once per pin, regardless of the
> number of configurations. This way the slew rate disablement will also
> work for cases where pins have multiple configurations.
>
> Fixes: 440b144978ba ("pinctrl: at91-pio4: add support for slew-rate")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Patch applied!
Yours,
Linus Walleij
prev parent reply other threads:[~2021-04-10 0:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 8:25 [PATCH] pinctrl: at91-pio4: Fix slew rate disablement Tudor Ambarus
2021-04-09 9:59 ` Claudiu.Beznea
2021-04-09 12:11 ` Ludovic.Desroches
2021-04-10 0:08 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbRfnZT9OU3FccZ7vny+Ami=k+dkDr4Lo7w_JOgzotX9A@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).