From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9980C61DA4 for ; Wed, 15 Mar 2023 08:42:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231718AbjCOImW (ORCPT ); Wed, 15 Mar 2023 04:42:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231679AbjCOImS (ORCPT ); Wed, 15 Mar 2023 04:42:18 -0400 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B95426BC13 for ; Wed, 15 Mar 2023 01:42:15 -0700 (PDT) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-5416b0ab0ecso224861977b3.6 for ; Wed, 15 Mar 2023 01:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678869735; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XTuGpc9zZDajgS9JdSbz5gYMdquT7uBEBxyEc8YStMs=; b=X8dfDUdc1qERLh7GivTSF6wAoPsVAkvj2ArHJf+sy5lK6lCJ+gnt6wL8G/qq14xTSw mjda5Rut3a1LWApmKqwfqQTT+tSBy26JXXW25TL9FtRcv9N6sx/LgxDS08V/QhsObugK NPhFuy1fii5SXPjmXcWltoGvZ6O5zXLeT6G2mVMXU285VJC3/FnnB0qxQjSQBWCD73sb /rvd5t2nXr/fON39K8yDlmtX/XXXNBJXURsvDMLp87WsLKuIFCJcj+zScVTEDm7QRkIs JxXTDcIVqpp185Vi2Vqj2pWjdXkl22umV2cZKBxBJtkQkgT1Lrsv7TWOmyXJuVuz3FE+ 3XKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678869735; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XTuGpc9zZDajgS9JdSbz5gYMdquT7uBEBxyEc8YStMs=; b=1AGxmy1t3VeFoekhWgsZhvlYoKbBbLU9Xja0tnvqNdsvgbiA7RAqq7mpcIS1YggrXg cAoqsY7bXeG8gCOen6SGD/QqvozcYVLdwWQ7aiXy3qdzyzKBrb0QcTpeVbwnVrQaud5L mWJFJON5/D5AP1HkM4dQ5ArpYdr7EksrMvyHfl52etL91ivzdkE2mzglQvfuHjsuzNOC DFeTBR/9PwsZOVkCFoxi8a6GVQ0xr3OQplnou4Pw7HtwZVeOEPG7eyOunWmGF8lsVZge abBmyMwVExRCwuZTpCYHiCSroDdc7h+oh1bCAAiZw+4/lAF2ya5o2PGEsJjM64rMQ3U8 pEgw== X-Gm-Message-State: AO0yUKW4D5UoRRkQyIP0zDXkEGMRQ8YPU3x8KzYI9KOubylRej7k41Zk bZgNyw/AINToY2NfB83cQZ0x68y+1YxAazY/jTzTZg== X-Google-Smtp-Source: AK7set+PctbN8J4oXDXLyGrk3edHfMzatYBNgyGgTDyeQWW1ATtsR/bDqC9DIp18hftEPIAszZ48FGEmsyi1yIHsDoc= X-Received: by 2002:a81:ad19:0:b0:541:a0ab:bd28 with SMTP id l25-20020a81ad19000000b00541a0abbd28mr6948301ywh.4.1678869734933; Wed, 15 Mar 2023 01:42:14 -0700 (PDT) MIME-Version: 1.0 References: <20230314121216.413434-1-schnelle@linux.ibm.com> <20230314121216.413434-10-schnelle@linux.ibm.com> In-Reply-To: <20230314121216.413434-10-schnelle@linux.ibm.com> From: Linus Walleij Date: Wed, 15 Mar 2023 09:42:03 +0100 Message-ID: Subject: Re: [PATCH v3 09/38] gpio: add HAS_IOPORT dependencies To: Niklas Schnelle Cc: Arnd Bergmann , Bartosz Golaszewski , Greg Kroah-Hartman , Bjorn Helgaas , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Niklas, thanks for your patch! On Tue, Mar 14, 2023 at 1:12=E2=80=AFPM Niklas Schnelle wrote: > > In a future patch HAS_IOPORT=3Dn will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle > --- > drivers/gpio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 13be729710f2..5a874e67fc13 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -688,7 +688,7 @@ config GPIO_VISCONTI > > config GPIO_VX855 > tristate "VIA VX855/VX875 GPIO" > - depends on (X86 || COMPILE_TEST) && PCI > + depends on (X86 || COMPILE_TEST) && PCI && HAS_IOPORT But is this the right fix? Further down in the Kconfig we have: menu "Port-mapped I/O GPIO drivers" depends on X86 # Unconditional I/O space access config GPIO_I8255 tristate select GPIO_REGMAP (...) Isn't the right fix to: 1) Move this Kconfig entry (VX855) down under the Port-mapped /O drivers, and then: 2) Make the whole submenu for port-mapped IO drivers depend on X86 && HAS_IOPORT Yours, Linus Walleij