From: Linus Walleij <linus.walleij@linaro.org>
To: Michael Walle <michael@walle.cc>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: fix OOB access in quirk callbacks
Date: Fri, 16 Sep 2022 13:19:04 +0200 [thread overview]
Message-ID: <CACRpkdbSkLxG8YiBPvFPuRm73iBXXB3FmChHV113dLXvSnpHfw@mail.gmail.com> (raw)
In-Reply-To: <20220916110118.446132-1-michael@walle.cc>
On Fri, Sep 16, 2022 at 1:01 PM Michael Walle <michael@walle.cc> wrote:
> Commit a2b5e207cade ("gpiolib: rework quirk handling in of_find_gpio()")
> introduced an array of quirk functions which get iterated over. But a
> sentinal value is missing. Add it.
>
> Fixes: a2b5e207cade ("gpiolib: rework quirk handling in of_find_gpio()")
> Signed-off-by: Michael Walle <michael@walle.cc>
Looks correct, an alternative would be to have the for-loop use
ARRAY_SIZE() but this is just as good.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-09-16 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 11:01 [PATCH] gpiolib: fix OOB access in quirk callbacks Michael Walle
2022-09-16 11:19 ` Linus Walleij [this message]
2022-09-16 11:37 ` Conor.Dooley
2022-09-16 13:13 ` Dmitry Torokhov
[not found] ` <CGME20220916132011eucas1p1360b9cc02cc108556fe80fab8d89567d@eucas1p1.samsung.com>
2022-09-16 13:20 ` Marek Szyprowski
2022-09-19 17:27 ` Biju Das
2022-09-20 6:01 ` Biju Das
2022-09-20 6:31 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbSkLxG8YiBPvFPuRm73iBXXB3FmChHV113dLXvSnpHfw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).