From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3B17C3A589 for ; Sun, 18 Aug 2019 22:20:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 911082186A for ; Sun, 18 Aug 2019 22:20:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WQo7LW0w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726307AbfHRWUP (ORCPT ); Sun, 18 Aug 2019 18:20:15 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:33802 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726083AbfHRWUP (ORCPT ); Sun, 18 Aug 2019 18:20:15 -0400 Received: by mail-lf1-f67.google.com with SMTP id b29so7550711lfq.1 for ; Sun, 18 Aug 2019 15:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oDJV2qKgc2rE1ZecO56MT3ujkmelBSa9vGB/ZXufqTw=; b=WQo7LW0wZCePzyiGp719cN5hGt2IqiOZor8+bvWmUAuHbV9PGpTkPF2bK8mSoOXKsk cXos23XIkSNlw0j+eYIVrAy4wm2b3mzq63weuFYrOh9fayfx7WXFe8iSR6qpRdjO706B rZ+5VK/R0mvml612IDYouJwZmejn8+fTgFXdMcvHDx9HRgqz5GEK4f9LALcvvM6rUbci M4mKmHbo8CAYGNbRwBoRtp9vQBSecxXLMFdsHbhuwir5Dk/WpwGKyZBA0s/Rdsr5+nHk jlS3RDdEtsGYcj1oAF3qTYjb6o7I26Q1FPM0SBih/XnZdml1vUXnn5vOE0lsOwhb0Ff8 6Chw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oDJV2qKgc2rE1ZecO56MT3ujkmelBSa9vGB/ZXufqTw=; b=B2IGRy4O9flLp+PZKbFgCEWNBUPByN2FbIAVGUURSp1RuuVGJmBklLg8tkiiPyTuU3 QTKsYCoKGQq5+UAWL+Ro0HtvM4QlMgHYFXsebkdEnSr0RG2TEgpno8i6NC/173/4bbIF Es/986oEm0aoGJAQcXPz7+OHNMgWYFJrNxqmQe5W2iVeki5hnZR3avNwbAhm7RVjoZjc jbhvhgiO9rCEOUt93zgLKuOOl/9udCg0TAfW+lKMZ8JqArD8mN8XLStkYqZ9x30l3ZL9 FnNgVX+GN4jAf30v/Wcls7PUXexmGvnGTGtXM2hQtHN9r+YhqLfO5MYR9EQeBMTGPYSb T5og== X-Gm-Message-State: APjAAAVn/InDjVmlou10UCXx23eY77BLrzVj50y7jMzG3aFdKbVeMKBu c0CJCs9HpRCqMWEUb+jGUpeE8J0w9nzeTDe3uLeQaw== X-Google-Smtp-Source: APXvYqy5zNUWEXYZ2BNwjMv+MHdjmq2+twXb9Dmljui/KTewQHGrsVYvarl4oFwHNOai9V/3ApArVT6G7+uz+EzX27Y= X-Received: by 2002:ac2:5939:: with SMTP id v25mr10723641lfi.115.1566166813184; Sun, 18 Aug 2019 15:20:13 -0700 (PDT) MIME-Version: 1.0 References: <1565984527-5272-1-git-send-email-skomatineni@nvidia.com> <1565984527-5272-2-git-send-email-skomatineni@nvidia.com> In-Reply-To: <1565984527-5272-2-git-send-email-skomatineni@nvidia.com> From: Linus Walleij Date: Mon, 19 Aug 2019 00:20:01 +0200 Message-ID: Subject: Re: [PATCH v9 01/22] pinctrl: tegra: Fix write barrier placement in pmx_writel To: Sowjanya Komatineni Cc: "thierry.reding@gmail.com" , Jon Hunter , Thomas Gleixner , Jason Cooper , Marc Zyngier , Stefan Agner , Mark Rutland , Peter De Schrijver , Prashant Gaikwad , Stephen Boyd , linux-clk , "open list:GPIO SUBSYSTEM" , jckuo@nvidia.com, Joseph Lo , talho@nvidia.com, linux-tegra@vger.kernel.org, "linux-kernel@vger.kernel.org" , Mikko Perttunen , spatra@nvidia.com, Rob Herring , Dmitry Osipenko , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "Rafael J. Wysocki" , viresh kumar , Linux PM list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 16, 2019 at 9:42 PM Sowjanya Komatineni wrote: > > pmx_writel uses writel which inserts write barrier before the > register write. > > This patch has fix to replace writel with writel_relaxed followed > by a readback and memory barrier to ensure write operation is > completed for successful pinctrl change. > > Acked-by: Thierry Reding > Reviewed-by: Dmitry Osipenko > Signed-off-by: Sowjanya Komatineni Took out the previous patches and applied this instead. Yours, Linus Walleij