From: Linus Walleij <linus.walleij@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <chris@printf.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Gross <agross@codeaurora.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v2] mmc: mmci: Add qcom dml support to the driver.
Date: Wed, 23 Jul 2014 16:52:39 +0200 [thread overview]
Message-ID: <CACRpkdbX350uaHHFHpy7km0Pu4aiSqu-bdontdhJiRM39k-LUA@mail.gmail.com> (raw)
In-Reply-To: <1405716797-28122-1-git-send-email-srinivas.kandagatla@linaro.org>
On Fri, Jul 18, 2014 at 10:53 PM, Srinivas Kandagatla
<srinivas.kandagatla@linaro.org> wrote:
> On Qualcomm APQ8064 SOCs, SD card controller has an additional glue
> called DML (Data Mover Local/Lite) to assist dma transfers.
> This hardware needs to be setup before any dma transfer is requested.
> DML itself is not a DMA engine, its just a gule between the SD card
> controller and dma controller.
>
> Most of this code has been ported from qualcomm's 3.4 kernel.
>
> This patch adds the code necessary to intialize the hardware and setup
> before doing any dma transfers.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> Changes since v1:
> - Added licence text as spotted by Stephen B.
> - Simplified dma channel lookup as suggested by Stephen B.
> - Removed unnecessary parens spotted by Stephen B.
> - in general some cleanup done.
>
> Changes since RFC:
> - Moved qcom_dml.* to mmci_qcom_dml.* as suggested by Linus W.
> - added BAM DMA dependency in Kconfig as suggested by Linus W
I really like this v2 version.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2014-07-23 14:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 11:48 [RFC PATCH] mmc: mmci: Add qcom dml support to the driver Srinivas Kandagatla
2014-07-11 13:49 ` Linus Walleij
2014-07-11 19:36 ` Srinivas Kandagatla
2014-07-17 19:36 ` [PATCH v1] " Srinivas Kandagatla
2014-07-17 19:41 ` Srinivas Kandagatla
2014-07-17 23:06 ` Stephen Boyd
2014-07-18 6:42 ` Srinivas Kandagatla
2014-07-18 20:53 ` [PATCH v2] " Srinivas Kandagatla
2014-07-23 14:52 ` Linus Walleij [this message]
2014-07-23 22:58 ` Stephen Boyd
2014-07-25 4:07 ` Srinivas Kandagatla
2014-07-28 6:22 ` [PATCH v3] " Srinivas Kandagatla
2014-07-29 2:50 ` [PATCH v4] " Srinivas Kandagatla
2014-07-29 17:55 ` Stephen Boyd
2014-07-30 4:12 ` Srinivas Kandagatla
2014-08-12 8:40 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbX350uaHHFHpy7km0Pu4aiSqu-bdontdhJiRM39k-LUA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=agross@codeaurora.org \
--cc=chris@printf.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=srinivas.kandagatla@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).