linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gpio: lpc18xx: convert GPIO_LPC18XX from bool to tristate
@ 2016-06-05 18:23 Paul Gortmaker
  2016-06-08  9:04 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2016-06-05 18:23 UTC (permalink / raw)
  To: linux-kernel
  Cc: Paul Gortmaker, Joachim Eastwood, Linus Walleij,
	Alexandre Courbot, linux-gpio

The Kconfig currently controlling compilation of this code is:

 config GPIO_LPC18XX
       bool "NXP LPC18XX/43XX GPIO support"

...meaning that it currently is not being built as a module by anyone.

When targeting orphaned modular code in non-modular drivers, this
came up.  Joachim indicated that the driver was actually meant to
be tristate but ended up bool by accident.  So here we make it
tristate instead of removing the modular code that was essentially
orphaned.

Cc: Joachim Eastwood <manabian@gmail.com>
Acked-by: Joachim Eastwood <manabian@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 92443817b1ae..03aaa2a1f431 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -249,7 +249,7 @@ config GPIO_LOONGSON
 	  driver for GPIO functionality on Loongson-2F/3A/3B processors.
 
 config GPIO_LPC18XX
-	bool "NXP LPC18XX/43XX GPIO support"
+	tristate "NXP LPC18XX/43XX GPIO support"
 	default y if ARCH_LPC18XX
 	depends on OF_GPIO && (ARCH_LPC18XX || COMPILE_TEST)
 	help
-- 
2.8.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gpio: lpc18xx: convert GPIO_LPC18XX from bool to tristate
  2016-06-05 18:23 [PATCH] gpio: lpc18xx: convert GPIO_LPC18XX from bool to tristate Paul Gortmaker
@ 2016-06-08  9:04 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-06-08  9:04 UTC (permalink / raw)
  To: Paul Gortmaker
  Cc: linux-kernel, Joachim Eastwood, Alexandre Courbot, linux-gpio

On Sun, Jun 5, 2016 at 8:23 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
>
>  config GPIO_LPC18XX
>        bool "NXP LPC18XX/43XX GPIO support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> When targeting orphaned modular code in non-modular drivers, this
> came up.  Joachim indicated that the driver was actually meant to
> be tristate but ended up bool by accident.  So here we make it
> tristate instead of removing the modular code that was essentially
> orphaned.
>
> Cc: Joachim Eastwood <manabian@gmail.com>
> Acked-by: Joachim Eastwood <manabian@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-08  9:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-05 18:23 [PATCH] gpio: lpc18xx: convert GPIO_LPC18XX from bool to tristate Paul Gortmaker
2016-06-08  9:04 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).