From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94164C4338F for ; Mon, 16 Aug 2021 23:00:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 707C160E09 for ; Mon, 16 Aug 2021 23:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232636AbhHPXBO (ORCPT ); Mon, 16 Aug 2021 19:01:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232562AbhHPXBK (ORCPT ); Mon, 16 Aug 2021 19:01:10 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CBBFC0613C1 for ; Mon, 16 Aug 2021 16:00:38 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id h9so29768244ljq.8 for ; Mon, 16 Aug 2021 16:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qCWu86tois4HzDjhxB5sPemRVqiKsSoDbxypDi9Z5+0=; b=z1v7oH+A7DDJ+ZpK2dUBsqz+f3S5ioTGJlgemaOwMO/L1AfOi49FHv8vz2Gyw2Iib1 cOikpkgggD63UmFz1/ychby9CDBTIMxUrHzJcpJr90wnfh64TPArcOReOXV6qvNB/W3j iX2vHy8T/MHeKjU1mY5t6zsezU78E7DcyjiUoJ4bC2dI8EiV0EH6h0LwCQM3Kp1cL+wI cgdJpqHJiHNMSx8jUT0YcbhCDOGCJ18DbQjQC0pTRuHO4Yx3p4k1MTUgVWeIWbGmsTZ3 86XeyMe22JZhDxgOpJeLpCINFeRPUIDOiYjfXU/sKuhlT+/TrYCjtXzL5V7X14ElwzLS k2mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qCWu86tois4HzDjhxB5sPemRVqiKsSoDbxypDi9Z5+0=; b=kOIyN5CL4VPEMrN5NNQc1dTnWnnbh3GnXoRK0g/23zQtdnymMeTsMZZf2m5M3XG2at cyF+0KkaIbfmQ5nqE1tsUsHI7cieZvEphPtpkG4O1g7hN5PgGqxOCb9fQ2IVEOwq/bBO 7wcMGZhjAZERKXD1+ukqpDDKk92/oGVAdaqL9/WHeKS8b0J3DHKtZXim/aqC2M5QWD5I 5rSp0SgndLOTHqNokt7+NaTE1ZlufwZQaj3r7vL3i6D3b+NCjURHy5a6W5+BNhcT5sTM F9ODMQlpnCMU5Trvk4Wr5aASWuqaO8NUsgrnW+m49aEki/W+l7f+WXvpC88Z/xmoiXy2 Ey8Q== X-Gm-Message-State: AOAM530vas9AYactgt5/2SJ6tdc2FQg3UIWUjJXBUuGvzAgaXU8nEg5z fBuEVdkL8Cv1mtyL0k6PW6+jXjOJirsKisstc3kJDg== X-Google-Smtp-Source: ABdhPJxKcr3tDBh889ZdkpDoJwN0ES9RscVrpyGEFVwDUZlW9BP1duIsjDpHOms2QM93AclfvKwqHgphf+CtZyBXZVA= X-Received: by 2002:a05:651c:1507:: with SMTP id e7mr491801ljf.368.1629154836469; Mon, 16 Aug 2021 16:00:36 -0700 (PDT) MIME-Version: 1.0 References: <20210710081722.1828-1-zhiyong.tao@mediatek.com> <20210710081722.1828-2-zhiyong.tao@mediatek.com> <1626940470.29611.9.camel@mhfsdcap03> <07388dac4e25e0f260725e8f80ba099d5aa80949.camel@mediatek.com> <4fd12d5c53f6492e5fa3ba94a78b9a149f5b6ed9.camel@mediatek.com> In-Reply-To: From: Linus Walleij Date: Tue, 17 Aug 2021 01:00:25 +0200 Message-ID: Subject: Re: [PATCH v10 1/2] dt-bindings: pinctrl: mt8195: add rsel define To: Chen-Yu Tsai Cc: "zhiyong.tao" , Rob Herring , Mark Rutland , Matthias Brugger , Sean Wang , srv_heupstream , hui.liu@mediatek.com, Eddie Huang , Light Hsieh , Biao Huang , Hongzhou Yang , Sean Wang , Seiya Wang , Devicetree List , LKML , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 5:38 PM Chen-Yu Tsai wrote: > On Mon, Aug 16, 2021 at 6:48 PM zhiyong.tao wrote: > > > I'll take that as "use SI units whenever possible and reasonable". > > > > ==> so It doesn't need to change the define, is it right? > > we will keep the common define. > > Actually I think it would be possible and reasonable to use SI units > in this case, since you are the vendor and have the resistor values > to implement the support. Having different sets of values for different > chips is nothing out of the ordinary. We already have to account for > different number of pins and different pin functions. That is what > compatible strings are for. I fully agree with Chen-Yu's analysis here. Zhiyong can you make an attempt to use SI units (Ohms) and see what it will look like? I think it will look better for users and it will be less risk to make mistakes. Yours, Linus Walleij