From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933928AbcJTWIF (ORCPT ); Thu, 20 Oct 2016 18:08:05 -0400 Received: from mail-qt0-f170.google.com ([209.85.216.170]:33270 "EHLO mail-qt0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933721AbcJTWID (ORCPT ); Thu, 20 Oct 2016 18:08:03 -0400 MIME-Version: 1.0 In-Reply-To: <1474991325-1754-1-git-send-email-narmstrong@baylibre.com> References: <1474991325-1754-1-git-send-email-narmstrong@baylibre.com> From: Linus Walleij Date: Fri, 21 Oct 2016 00:08:01 +0200 Message-ID: Subject: Re: [PATCH v2] pinctrl: Add SX150X GPIO Extender Pinctrl Driver To: Neil Armstrong , Andrey Smirnov Cc: Peter Rosin , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , Wei Chen , Roland Stigge , Vladimir Zapolskiy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2016 at 5:48 PM, Neil Armstrong wrote: > Since the I2C sx150x GPIO expander driver uses platform_data to manage > the pins configurations, rewrite the driver as a pinctrl driver using > pinconf to get/set pin configurations from DT or debugfs. > > The pinctrl driver is functionnally equivalent as the gpio-only driver > and can use DT for pinconf. The platform_data confirmation is dropped. > > This patchset removed the gpio-only driver and selects the Pinctrl driver > config instead. This patchset also migrates the gpio dt-bindings to pinctrl > and add the pinctrl optional properties. > > The driver was tested with a SX1509 device on a BeagleBone black with > interrupt support and on an X86_64 machine over an I2C to USB converter. > > Signed-off-by: Neil Armstrong I think we're ready to apply this to the GPIO and pinctrl trees. Could you: - Rebase on top of v4.9-rc1 (fails to apply for me) - Add the collected ACKs - See if Andrey can provide an additional Test tag - Resend Also please look at Andreys patches to see if there is some good inspiration for further cleanups. Yours, Linus Walleij