From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D386CC433B4 for ; Sat, 1 May 2021 11:59:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B297A613F8 for ; Sat, 1 May 2021 11:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231977AbhEAMAK (ORCPT ); Sat, 1 May 2021 08:00:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231886AbhEAMAJ (ORCPT ); Sat, 1 May 2021 08:00:09 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5AAAC06138B for ; Sat, 1 May 2021 04:59:18 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id 12so1059851lfq.13 for ; Sat, 01 May 2021 04:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QLxSp/ePlciHnCzVMGdXgyEZo0R6BmfwYtxDKjI/pqU=; b=jcIi+kb7+jywxzREwePLOZyikDcoPK0Z0M1f/JhBnLif3jWV6ATJl0nXzhuKTa72Qm PQMeKbrrwBH5qU6RcI+NNhRgPjaBrwIYgPMpQvGGv4MtxK1r7IIEWX/CQ02RVRl1iFbP P42ki89fVr+tczmJUY02sjARyeOt/wHldYK1fffQ9dF5dcWQqYv7a03b2KoKkb/yXUB7 czOvMyriPuA18ukQogxg9Z3Yk57cksDHyHt43PE/7IA3zPwZH4HW8aFNpNk1EGarsOXl pUjfQOfyivF2OAuny4eJEDvj7wVkpPBX0oatWIhPAKVSouQyEufzyxJr1bzere5HjMFs edJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QLxSp/ePlciHnCzVMGdXgyEZo0R6BmfwYtxDKjI/pqU=; b=OZvyysVOuPAOp2XzoMsYc15CtTx7dgi9CGh8iuxW2vsXU3VK1MTdNOOy+n13GV1ySd ojPO98KolxzdVDIxIwbtmecg2/r5XHmNSD3rMc7sFnDult6+nqhsQQUV2fhdrUm0a43S 9vlGdhKwNlMQmv6x0z5iPUwb9QoVrKQGC37wcFG3Te6tnIYAZnixrUa5zOOpGPWpvKYS UMuhgpoH+wTy4oSR8QDPonDYJi+XoaKGLc8Z0QO8CMQfrxhyhtMB5XlWxcslmXKUhQMR tJmzRmHbMow+taweWvj9dfuzA8PF9sAeLUmKW8JuPiFDw3gNt/Mcwes7TGIQdLwlicoV 5GpA== X-Gm-Message-State: AOAM531phWWH+5s/bVXxBYn2Ej2f/tvTyZIIzLAyJFC/rq+W1YH2dK6d +q2+Bei0IYRqFvuFItmUbxSZfYS5MT+3SxUkCZ5vtQ== X-Google-Smtp-Source: ABdhPJw+F9WmElJwhUk24Nw7bpvwEd3U15o9b5hWV9qrpBy3C0X7Zj7MCbUNd4hF1kIE4C9w9FMOjoMDoXiThg28GGk= X-Received: by 2002:a05:6512:3e1f:: with SMTP id i31mr6880595lfv.29.1619870357179; Sat, 01 May 2021 04:59:17 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.9.I3e68fa38c4ccbdbdf145cad2b01e83a1e5eac302@changeid> In-Reply-To: <20210423095743.v5.9.I3e68fa38c4ccbdbdf145cad2b01e83a1e5eac302@changeid> From: Linus Walleij Date: Sat, 1 May 2021 13:59:06 +0200 Message-ID: Subject: Re: [PATCH v5 09/20] drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , MSM , Rob Clark , Stanislav Lisovskiy , Stephen Boyd , Steev Klimaszewski , Maarten Lankhorst , linux-i2c , Bjorn Andersson , "open list:DRM PANEL DRIVERS" , Daniel Vetter , David Airlie , Robert Foss , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson wrote: > Let's use the newly minted aux bus to break up the driver into sub > drivers. We're not doing a full breakup here: all the code is still in > the same file and remains largely untouched. The big goal here of > using sub-drivers is to allow part of our code to finish probing even > if some other code needs to defer. This can solve some chicken-and-egg > problems. Specifically: > - In commit 48834e6084f1 ("drm/panel-simple: Support hpd-gpios for > delaying prepare()") we had to add a bit of a hack to simpel-panel > to support HPD showing up late. We can get rid of that hack now > since the GPIO part of our driver can finish probing early. > - We have a desire to expose our DDC bus to simple-panel (and perhaps > to a backlight driver?). That will end up with the same > chicken-and-egg problem. A future patch to move this to a sub-driver > will fix it. > - If/when we support the PWM functionality present in the bridge chip > for a backlight we'll end up with another chicken-and-egg > problem. If we allow the PWM to be a sub-driver too then it solves > this problem. > > Signed-off-by: Douglas Anderson > --- > > Changes in v5: > - Fix module compile problems (Bjorn + kbuild bot) > - Remove useless MODULE_DEVICE_TABLE (Bjorn). This is generally a good idea. I have no idea when to use auxbus or MFD but I trust that you researched that so: Acked-by: Linus Walleij Yours, Linus Walleij