From: Linus Walleij <linus.walleij@linaro.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Lee Jones <lee.jones@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Cory Maccarrone <darkstar6262@gmail.com>,
David Dajun Chen <dchen@diasemi.com>,
Dong Aisheng <dong.aisheng@linaro.org>,
Eric Miao <eric.miao@marvell.com>,
Graeme Gregory <gg@slimlogic.co.uk>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Haojian Zhuang <haojian.zhuang@marvell.com>,
jinyoungp@nvidia.com,
Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>,
Laxman Dewangan <ldewangan@nvidia.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Mattias NILSSON <mattias.i.nilsson@stericsson.com>,
Michael Hennerich <michael.hennerich@analog.com>,
Mike Rapoport <mike@compulab.co.il>,
ext Tony Lindgren <tony@atomide.com>,
Venu Byravarasu <vbyravarasu@nvidia.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
patches@opensource.cirrus.com,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH v2 00/22] mfd: demodularization of non-modular drivers
Date: Wed, 5 Dec 2018 12:50:51 +0100 [thread overview]
Message-ID: <CACRpkdbaU03uDbHnRuCp0ef2Zzbb4XcAGgUCn=xBfAxuCEciOw@mail.gmail.com> (raw)
In-Reply-To: <1543811009-15112-1-git-send-email-paul.gortmaker@windriver.com>
On Mon, Dec 3, 2018 at 5:24 AM Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> [v1 --> v2: add some more commits as requested by Lee (MFD maintainer),
> update the 00/NN text; re-do build and link testing on new linux-next. ]
>
> This group of MFD drivers are all controlled by "bool" Kconfig settings,
> but contain various amounts of largely pointless uses of infrastructure
> related to modular operations, even though they can't be built modular.
>
> We can easily remove/replace all of it. We are trying to make driver
> code consistent with the Makefiles/Kconfigs that control them. This
> means not using modular functions/macros for drivers that can never be
> built as a module. Some of the downfalls this oversight leads to are:
This series:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
IMO it is clearly the right thing to do, moving a whole bunch
of clutter out of the way so we can see clearly and the effect
of getting rid of the <linux/module.h> is a substantial improvement
in its own right.
Yours.
Linus Walleij
next prev parent reply other threads:[~2018-12-05 11:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 4:23 [PATCH v2 00/22] mfd: demodularization of non-modular drivers Paul Gortmaker
2018-12-03 4:23 ` [PATCH 01/22] mfd: aat2870-core: Make it explicitly non-modular Paul Gortmaker
2018-12-03 4:23 ` [PATCH 02/22] mfd: adp5520: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 03/22] mfd: as3711: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 04/22] mfd: da903x: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 05/22] mfd: da9052-*: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 06/22] mfd: da9055-i2c: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 07/22] mfd: da9055-core: make " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 08/22] mfd: db8500-prcmu: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-07 12:25 ` Linus Walleij
2018-12-03 4:23 ` [PATCH 09/22] mfd: htc-i2cpld: Make it explicitly non-modular Paul Gortmaker
2018-12-03 4:23 ` [PATCH 10/22] mfd: max8925-core: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-03 4:23 ` [PATCH 11/22] mfd: rc5t583: Make it explicitly non-modular Paul Gortmaker
2018-12-03 4:23 ` [PATCH 12/22] mfd: sta2x11: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-03 11:14 ` Lee Jones
2018-12-03 15:07 ` Paul Gortmaker
2018-12-04 9:23 ` Davide Ciminaghi
2018-12-07 16:39 ` Alessandro Rubini
2018-12-03 4:23 ` [PATCH 13/22] mfd: syscon: Make it explicitly non-modular Paul Gortmaker
2018-12-03 4:23 ` [PATCH 14/22] mfd: tps65090: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 15/22] mfd: tps65910: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 16/22] mfd: tps80031: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 17/22] mfd: wm831x-spi: " Paul Gortmaker
2018-12-03 4:23 ` [PATCH 18/22] mfd: wm831x-i2c: " Paul Gortmaker
2018-12-05 11:38 ` Charles Keepax
2018-12-07 18:16 ` Paul Gortmaker
2018-12-03 4:23 ` [PATCH 19/22] mfd: wm831x-core: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-05 11:36 ` Charles Keepax
2018-12-03 4:23 ` [PATCH 20/22] mfd: wm8350-i2c: Make it explicitly non-modular Paul Gortmaker
2018-12-05 11:39 ` Charles Keepax
2018-12-03 4:23 ` [PATCH 21/22] mfd: wm8350-core: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-05 11:39 ` Charles Keepax
2018-12-03 4:23 ` [PATCH 22/22] mfd: wm8400-core: Make it explicitly non-modular Paul Gortmaker
2018-12-05 11:41 ` Charles Keepax
2018-12-05 11:35 ` [PATCH v2 00/22] mfd: demodularization of non-modular drivers Charles Keepax
2018-12-05 11:48 ` Linus Walleij
2018-12-05 13:40 ` Charles Keepax
2018-12-05 11:50 ` Linus Walleij [this message]
2018-12-05 12:01 ` Steve Twiss
2018-12-05 12:12 ` Steve Twiss
2018-12-05 18:08 ` Paul Gortmaker
[not found] ` <20181207203021.GR23156@windriver.com>
2019-08-07 10:43 ` Steve Twiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbaU03uDbHnRuCp0ef2Zzbb4XcAGgUCn=xBfAxuCEciOw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=darkstar6262@gmail.com \
--cc=dchen@diasemi.com \
--cc=dong.aisheng@linaro.org \
--cc=eric.miao@marvell.com \
--cc=g.liakhovetski@gmx.de \
--cc=gg@slimlogic.co.uk \
--cc=haojian.zhuang@marvell.com \
--cc=jedu@slimlogic.co.uk \
--cc=jinyoungp@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mattias.i.nilsson@stericsson.com \
--cc=michael.hennerich@analog.com \
--cc=mike@compulab.co.il \
--cc=patches@opensource.cirrus.com \
--cc=paul.gortmaker@windriver.com \
--cc=support.opensource@diasemi.com \
--cc=tony@atomide.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).