From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB877C4320E for ; Fri, 23 Jul 2021 15:43:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E56360C51 for ; Fri, 23 Jul 2021 15:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235603AbhGWPC0 (ORCPT ); Fri, 23 Jul 2021 11:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235472AbhGWPCZ (ORCPT ); Fri, 23 Jul 2021 11:02:25 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91FC5C061757 for ; Fri, 23 Jul 2021 08:42:58 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id q2so2226603ljq.5 for ; Fri, 23 Jul 2021 08:42:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O/f1g+Bd2m3qWx8HKI2UdTdvCSkFMuvtajEPkZseSXo=; b=P9WIEootakX6Goscgqro+lI7BeHd2NnvAGsPf77p8dHmtnMv5PdY+XquMleRjOo0en N8dQ9HMTolWKMbRpxmESYskXGStw0BdpZAQsqoXuhmojOIhJ53Sf6uQcQjQ9tG2RLPTZ DK4DQ5uJCDdpcyd+LAgvJ7+wh7S2b3FoMzV0i+2QMBVGLRM+mOsqIeADs/3lkS4+z1+A 99y88jczDL0H+qZ3diqcU528DJKCL2eP/9ale4Sv7vMfvEd7WnL0y/xqtS6t8elZqsEY MN5cWFh21q1qmIBNQNsH8VgYf4mbUd/8wEympPPSlUh8I046ULUvC167RulQd0mVko7O jnTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O/f1g+Bd2m3qWx8HKI2UdTdvCSkFMuvtajEPkZseSXo=; b=XLW3b6gY9irzNXsDc2YsCM89IYA7kxiIGABA46ifdrh7ae7nzizwJILQxTmM/O7RHQ pZ2+XWnrTvEyZs6bA5YSnYormqbhK2r1KtEFjElyQnqiVmRTEQCC9ZQ0ffvDgYVjDTSt yZfzKJ1dX2+/iANRc1Z2ZYWDUMBoA2ahJ99QJNm6MPqF74pVPZnnsCnCngwORyVqhFdJ XWVmPQH69baqRiW+JDqKhBgaaWeNjdHEce0H48Wvor764z3wV/lvBdeH5L8HXevugT4r h3K5fy7R+3YXajO1ggUHpbOvc93ChMKP0bVdxZB7B9SINUldr3OmoRsP0/k0bvzIetHk c30w== X-Gm-Message-State: AOAM533dVOAggxM/55GthtAokY7Eda+BIsrqM70QiJ8e/UuTGlyaBq53 RWVi858Vi/j3bzIvHrpsBeSdUzcPqa4NNqtoe2G8Nw== X-Google-Smtp-Source: ABdhPJy1g6Lo0FVctRSfD7xM4QliObCTb5e2mkP+drcrUUsa0a8KNePvOCiQfbXrF4S6/RGLWayNHJSo1qU6BxwNWB0= X-Received: by 2002:a05:651c:169a:: with SMTP id bd26mr3717379ljb.368.1627054976984; Fri, 23 Jul 2021 08:42:56 -0700 (PDT) MIME-Version: 1.0 References: <20210701080955.2660294-1-hsinyi@chromium.org> In-Reply-To: <20210701080955.2660294-1-hsinyi@chromium.org> From: Linus Walleij Date: Fri, 23 Jul 2021 17:42:46 +0200 Message-ID: Subject: Re: [PATCH v2] pinctrl: mediatek: Fix fallback behavior for bias_set_combo To: Hsin-Yi Wang Cc: Sean Wang , Zhiyong Tao , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hsin-Yi, On Thu, Jul 1, 2021 at 10:10 AM Hsin-Yi Wang wrote: > > Some pin doesn't support PUPD register, if it fails and fallbacks with > bias_set_combo case, it will call mtk_pinconf_bias_set_pupd_r1_r0() to > modify the PUPD pin again. > > Since the general bias set are either PU/PD or PULLSEL/PULLEN, try > bias_set or bias_set_rev1 for the other fallback case. If the pin > doesn't support neither PU/PD nor PULLSEL/PULLEN, it will return > -ENOTSUPP. > > Fixes: 81bd1579b43e ("pinctrl: mediatek: Fix fallback call path") > Signed-off-by: Hsin-Yi Wang > --- > v2: fix v1 comments Thanks for fixing this up so nicely, great work. Patch applied for fixes! Yours, Linus Walleij