From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751412AbbLUIqZ (ORCPT ); Mon, 21 Dec 2015 03:46:25 -0500 Received: from mail-ob0-f179.google.com ([209.85.214.179]:35541 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886AbbLUIqX (ORCPT ); Mon, 21 Dec 2015 03:46:23 -0500 MIME-Version: 1.0 In-Reply-To: <20151221160252.01e3ea76@canb.auug.org.au> References: <20151216143755.67915348@canb.auug.org.au> <20151221160252.01e3ea76@canb.auug.org.au> Date: Mon, 21 Dec 2015 09:46:22 +0100 Message-ID: Subject: Re: linux-next: build failure after merge of the gpio tree From: Linus Walleij To: Stephen Rothwell Cc: "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Yendapally Reddy Dhananjaya Reddy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 21, 2015 at 6:02 AM, Stephen Rothwell wrote: > Hi Linus, > > On Wed, 16 Dec 2015 14:37:55 +1100 Stephen Rothwell wrote: >> >> After merging the gpio tree, today's linux-next build (arm >> multi_v7_defconfig) failed like this: >> >> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe': >> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration] >> set_irq_flags(irq, IRQF_VALID); >> ^ >> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function) >> set_irq_flags(irq, IRQF_VALID); >> ^ >> >> Caused by commit >> >> 8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC") >> >> set_irq_flags was removed before v4.3-rc2 ... >> >> I have used the gpio tree from next-20151215 for today. > > I am still getting this error. Yeah I was applying the fix to the pin control tree, never fix stuff late on fridays... will apply the patch to the GPIO tree as well, I see no better solution. Yours, Linus Walleij