From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A9EFC4743F for ; Mon, 7 Jun 2021 08:10:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D5EA611C0 for ; Mon, 7 Jun 2021 08:10:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230303AbhFGIMJ (ORCPT ); Mon, 7 Jun 2021 04:12:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbhFGIMI (ORCPT ); Mon, 7 Jun 2021 04:12:08 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2731C061766 for ; Mon, 7 Jun 2021 01:10:13 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id s22so548797ljg.5 for ; Mon, 07 Jun 2021 01:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GFm0dzV1rxyymG1x9+b3biG2kx5e317PTQKCNEoutCQ=; b=glHZhLz1R6c51WmXVF1XClc9Rz0NQvEeCy5xpkih86MTpEQKmhYHYXcoTLQvRKxgPX YLka3TIohf1coxqIz3itfoP3QmK1/ULeC6doPcLEKfqI4obE3LwuSNoJPZKGkZxd9daX kK65Eal65LnkYXlNg1Mwun+w2S70cNM7kQcDr+3HWp01MQwXHqH9ImRUPuHCS5d32UfO HEmjox+N+/3dZegYvXccl3+ejXCMGLqjrbITQIbqXWVWUSH1OOPF8eF7ebtFzHjAQe0r IzFJhPJ7ndvwvbTQxgIbc/UFWTsY+QRm5YIHTV81bvf73h2IYvDNn16+gXbc8XjWZcJ3 CTNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GFm0dzV1rxyymG1x9+b3biG2kx5e317PTQKCNEoutCQ=; b=jVOpwv707+SMly46ycFM3c7165vRe4NsCx4UmunPbDgypcWx0eKZgBVn8dXGRI2JBH qjkj6yxkA8DJ3PB36s9KhjloTZ6b1blSnWlVyq/mbtfeF9tUaiCzKwKHxVcB6JWTxfyi XggmvgIZv7UkfN7KH3xzhTUK+NNIgcZR9t6TbskZhVDCDhHKkcbWDRVUOy5rmDGc12tt i5PfQITZHtG70EssGGHrrjG7p6+PslqdEozgN+T4DvHHlk4sRYMsXsHe9xkur9nlVNpW ixUhBJHqnSQZ7XtPd/iN+FBQXTn6V2fROV1HNfIarC5z/aBAfq3zQsMfzy5Mv9ybmhK6 us0A== X-Gm-Message-State: AOAM5312Qm6MuCspiINEAPSxj7ElrpvqdABdMFZyw7upBR0ik8CTDNoP X1G5j4NiGo1PIhhRPgwyjpfBARc75D82enR1HKvLEA== X-Google-Smtp-Source: ABdhPJwqI1MBFpKXCoH9g8iKyng0T9Fa/009mVPR+5u5x/F4tSdgGaxIoWEB9DKXPa/kIHk6QLVHZwYWXvGJF3J0Qhw= X-Received: by 2002:a2e:7811:: with SMTP id t17mr4349895ljc.368.1623053412251; Mon, 07 Jun 2021 01:10:12 -0700 (PDT) MIME-Version: 1.0 References: <20210607081145.1617593-1-yangyingliang@huawei.com> In-Reply-To: <20210607081145.1617593-1-yangyingliang@huawei.com> From: Linus Walleij Date: Mon, 7 Jun 2021 10:10:01 +0200 Message-ID: Subject: Re: [PATCH net-next v3] net: gemini: Use devm_platform_get_and_ioremap_resource() To: Yang Yingliang Cc: linux-kernel , netdev , Hans Ulli Kroll , "David S. Miller" , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 7, 2021 at 10:08 AM Yang Yingliang wrote: > Use devm_platform_get_and_ioremap_resource() to simplify > code. > > Signed-off-by: Yang Yingliang > --- > v3: > remove netdev_info(...) in gemini_ethernet_port_probe() Nice! Reviewed-by: Linus Walleij Yours, Linus Walleij