From: Linus Walleij <linus.walleij@linaro.org>
To: Andreas Larsson <andreas@gaisler.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
devicetree-discuss@lists.ozlabs.org,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH v2 2/6] of: Return -ENXIO from of_parse_phandle_with_args for too large index and return errors from of_gpio_named_count
Date: Fri, 1 Feb 2013 10:37:51 +0100 [thread overview]
Message-ID: <CACRpkdbfKmG37QRR54S9MiFMZ+g0x37=-uQ1nCtDaJbSk0hHEA@mail.gmail.com> (raw)
In-Reply-To: <1359471223-4794-3-git-send-email-andreas@gaisler.com>
On Tue, Jan 29, 2013 at 3:53 PM, Andreas Larsson <andreas@gaisler.com> wrote:
> This lets of_gpio_named_count return an errno on errors by being able to
> distinguish between reaching the end of the phandle list and getting some other
> error from of_parse_phandle_with_args.
>
> Return error from of_spi_register_master when there is an "cs-gpios" list for
> which gp_gpio_named_count fails.
>
> Adjust various drivers cope with error return from of_gpio_named_count,
> including via of_gpio_count.
>
> Signed-off-by: Andreas Larsson <andreas@gaisler.com>
> ---
> Changes since v1:
> - Handle error return values from calls to of_gpio_count
Looks correct to me, but I'm no DT-ninja.
For the GPIO portions:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-02-01 9:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 14:53 [PATCH v2 0/6] of, of_gpio, of_spi: Bugfix and improve of_parse_phandle_with_args, of_gpio_named_count and of_spi_register_master Andreas Larsson
2013-01-29 14:53 ` [PATCH v2 1/6] of: Return -EEXIST from of_parse_phandle_with_args for holes in phandle list Andreas Larsson
2013-01-29 14:53 ` [PATCH v2 2/6] of: Return -ENXIO from of_parse_phandle_with_args for too large index and return errors from of_gpio_named_count Andreas Larsson
2013-02-01 9:37 ` Linus Walleij [this message]
2013-02-10 23:56 ` Grant Likely
2013-01-29 14:53 ` [PATCH v2 3/6] of_spi: Initialize cs_gpios properly Andreas Larsson
2013-02-11 0:00 ` Grant Likely
2013-01-29 14:53 ` [PATCH v2 4/6] of_spi: Document cs_gpios and cs_gpio in kernel-doc Andreas Larsson
2013-02-11 0:06 ` Grant Likely
2013-01-29 14:53 ` [PATCH v2 5/6] of_spi: Add fetching of of_gpio flags to of_spi_register_master Andreas Larsson
2013-02-11 0:22 ` Grant Likely
2013-02-12 9:39 ` Andreas Larsson
2013-02-12 17:09 ` Grant Likely
2013-01-29 14:53 ` [PATCH v2 6/6] of_spi: Initialize cs_gpios and cs_gpio with -EEXIST Andreas Larsson
2013-02-11 0:23 ` Grant Likely
2013-02-12 9:46 ` Andreas Larsson
2013-02-12 18:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbfKmG37QRR54S9MiFMZ+g0x37=-uQ1nCtDaJbSk0hHEA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andreas@gaisler.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=software@gaisler.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).