From: Linus Walleij <linus.walleij@linaro.org>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Tony Lindgren <tony@atomide.com>, Sekhar Nori <nsekhar@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Javier Martinez Canillas <javier@dowhile0.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: omap: prevent module from being unloaded while in use
Date: Thu, 16 Jul 2015 14:27:17 +0200 [thread overview]
Message-ID: <CACRpkdbfPab9rv8Pz0gO5P69jbSQe-_ReCou=U4RHZyX--9SuQ@mail.gmail.com> (raw)
In-Reply-To: <1435245213-17858-1-git-send-email-grygorii.strashko@ti.com>
On Thu, Jun 25, 2015 at 5:13 PM, Grygorii Strashko
<grygorii.strashko@ti.com> wrote:
> OMAP GPIO driver allowed to be built as loadable module, but it
> doesn't set owner field in GPIO chip structure. As result,
> module_get/put() API is not working and it's possible to unload
> OMAP driver while in use:
>
> omap_gpio 48051000.gpio: REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED
>
> Hence, add missing configuration.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Fixes: cac089f9026e ('gpio: omap: Allow building as a loadable module')
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> Hi Linus,
>
> Seems this one is for 4.2-rc.
Yup applied for fixes with Alex' ACK.
The bigger fix is applied for devel and the best way to handle this
is open for discussion.
Yours,
Linus Walleij
prev parent reply other threads:[~2015-07-16 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 15:13 [PATCH] gpio: omap: prevent module from being unloaded while in use Grygorii Strashko
2015-06-30 13:52 ` Alexandre Courbot
2015-07-06 15:15 ` Grygorii Strashko
2015-07-16 12:27 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbfPab9rv8Pz0gO5P69jbSQe-_ReCou=U4RHZyX--9SuQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=gnurou@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=javier@dowhile0.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).