linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drivers: net: dsa: fix warning same module names
Date: Wed, 12 Jun 2019 14:36:44 +0200	[thread overview]
Message-ID: <CACRpkdbhRAdybqKdMgyM9Jy=eSJaRHjTpuOZO=KBgeaCbcP88Q@mail.gmail.com> (raw)
In-Reply-To: <20190612081147.1372-1-anders.roxell@linaro.org>

On Wed, Jun 12, 2019 at 10:11 AM Anders Roxell <anders.roxell@linaro.org> wrote:

> When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY
> enabled as loadable modules, we see the following warning:
>
> warning: same module names found:
>   drivers/net/phy/realtek.ko
>   drivers/net/dsa/realtek.ko
>
> Rework so the driver name is rtl8366 instead of realtek.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

Sorry for giving bad advice here on IRC... my wrong.

> -obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek.o
> -realtek-objs                   := realtek-smi.o rtl8366.o rtl8366rb.o
> +obj-$(CONFIG_NET_DSA_REALTEK_SMI) += rtl8366.o
> +rtl8366-objs                   := realtek-smi.o rtl8366-common.o rtl8366rb.o

What is common for this family is not the name rtl8366
(there is for example rtl8369 in this family, we just haven't
added it yet) but the common technical item is SMI.

So I would suggest something like:

obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek-smi.o
realtek-smi-objs := realtek-smi-core.o rtl8366.o rtl8366rb.o

I.e. rename the realtel-smi.c to realtek-smi-core.c instead
and go with that.

With that change:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

  reply	other threads:[~2019-06-12 12:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12  8:11 [PATCH v2] drivers: net: dsa: fix warning same module names Anders Roxell
2019-06-12 12:36 ` Linus Walleij [this message]
2019-06-12 13:16   ` Andrew Lunn
2019-06-12 18:39     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdbhRAdybqKdMgyM9Jy=eSJaRHjTpuOZO=KBgeaCbcP88Q@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=anders.roxell@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).