From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD914C282C7 for ; Sat, 26 Jan 2019 12:10:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DEFF218A6 for ; Sat, 26 Jan 2019 12:10:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="DAoNpvNA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729611AbfAZMKv (ORCPT ); Sat, 26 Jan 2019 07:10:51 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:38449 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbfAZMKu (ORCPT ); Sat, 26 Jan 2019 07:10:50 -0500 Received: by mail-lj1-f194.google.com with SMTP id c19-v6so10514940lja.5 for ; Sat, 26 Jan 2019 04:10:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qWt+a+DApXXFI1Z66adeohhEeOQI8/QFCZ31i+hC8ps=; b=DAoNpvNAai+Ul+1SZPMK2Lk3EP1oyCKUSQO1SHw9BI/MpPXGr1Nm9fpU/laydHmkse 2wzg3f0nY97yJtqrX1nuyPx0w9RvKpe4+rkEjUyy5zvxYkhxagXLmx/niVnYSCTX8+hl BP2lxQZFjeqqK8v4bb+08anBWYk9TkChT+PSs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qWt+a+DApXXFI1Z66adeohhEeOQI8/QFCZ31i+hC8ps=; b=PgUV1mYiR9fTKVEMO7weQB+/3GLpTyk6KlLYLUIPcMsEz4pd91kP1WKt0DbmiMABDp EoTArTdkDyoP7EwDouSdh0tFcRS8fY5xpW6+WJjUSoK4hUcwMYR3jPldfAUfRvxgbScb FhWAIE/+VK5zdoiF6R9frObyCFtJtmKkTfccybwKBjnceBvHieCr+4sTcZi18NALwWpc 9CMcKPm+OL+B1T8o6bOQzyzmShVjrGYCu+9llag0lSY/XjWXBAyMeDflmDvmdxiPtUyE kS0WJa4J0P0GQG5suImXkTAOwo+N9daE3GBwX30LXDIetoZJZyL2UmilBy1J2ccmy8WX UvXQ== X-Gm-Message-State: AJcUukdxC+PBsw1VP0yZct75WM2Rr0UXWQ9QKpu7C4gJaZ/iisM89x/f pWWowG4ddQpvqEr7LxDrrmlpwkq+1k34YE1JcMHMrg== X-Google-Smtp-Source: ALg8bN6NITiklHR3i0avIacW92OpM5c5UyspsWPojNI0W2bSlry2L4cujLNodG6FVgCOLP/zuDbx/5iCS4h6qungMrg= X-Received: by 2002:a2e:568d:: with SMTP id k13-v6mr12588444lje.105.1548504649038; Sat, 26 Jan 2019 04:10:49 -0800 (PST) MIME-Version: 1.0 References: <20190125200927.21045-1-paul@crapouillou.net> In-Reply-To: <20190125200927.21045-1-paul@crapouillou.net> From: Linus Walleij Date: Sat, 26 Jan 2019 13:10:37 +0100 Message-ID: Subject: Re: [PATCH 1/3] mmc: jz4740: Remove platform data and use standard APIs To: Paul Cercueil Cc: Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , Ulf Hansson , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-mips@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-mmc Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 25, 2019 at 9:09 PM Paul Cercueil wrote: > Drop the custom code to get the 'cd' and 'wp' GPIOs. The driver now > calls mmc_of_parse() which will init these from devicetree or > device properties. > > Also drop the custom code to get the 'power' GPIO. The MMC core > provides us with the means to power the MMC card through an external > regulator. > > Signed-off-by: Paul Cercueil Execellent patching! Reviewed-by: Linus Walleij For all three patches. Yours, Linus Walleij