From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECBC0CCA47B for ; Thu, 30 Jun 2022 11:57:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235128AbiF3L5G (ORCPT ); Thu, 30 Jun 2022 07:57:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234926AbiF3L5F (ORCPT ); Thu, 30 Jun 2022 07:57:05 -0400 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EFA75238A for ; Thu, 30 Jun 2022 04:57:01 -0700 (PDT) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-3137316bb69so176189237b3.10 for ; Thu, 30 Jun 2022 04:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T2nf43YSG2Rmj+bAJwbn+WqQ9U0uX95RW/bS0f0BEIk=; b=xX22BKzLNWetYuGqacglbCbctbEFAqaw/9VSCakoyY1uZ/lUsbRrOi5MPNjNdCKQN7 auegeivkAV5FQ+lTQkNytjNOQrKUT15ORn8L+4LjcV4/uZT3Ecv8R4+ZE2VzN/1pkJCB LTWU6L9wNQlbxiWOMY3eRQzSab60pao7/ezDEKGrL6FPkEZrhFYs3flAtJlnGJ67hw+W DuugEAx86feg+q2PbjwxvDQ7IXtr/G2VXfl/TsXaUiX539ecJD45jYNRoQ5QyTV8/qgz 8Y5gnJ6P5kyLFyFoIGcVUWqtd/mvRLwwkDlWsR9NkgrPm0BFzV0FtoyvPPkJU/bWtbjE CpQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T2nf43YSG2Rmj+bAJwbn+WqQ9U0uX95RW/bS0f0BEIk=; b=hJ0StVjtUBVn90j/D8ZTP95sRnxD+4IBGnzw/wMKtDNLh+gpdOubjf8LexM+XjAt2V /AtVoTIHcs/1TvwCGgzzbQ8ws9O9AILXmLkIWeJlclk5FqGorrlHOdCJBzs90a2F8Zy5 wuT5MwyjP5ekWaejD87He+ucuphVQ469rPoGS8zuovwxaKt8E/ET/XAQmkaEQMNCK3kt lI3PdmDCoLMdBMFkqCH5Bi+l1za5s54pr2eBAr4E4a1XZ8lyKXRKi0yWnj6my6+tDGSU 6k087sDqFNZgOVRFzsJBKdZ6j+FmdQilL1x8Y0MEbxu4qFjMB4o1SX1miPq4+ALNtjbS 0+ew== X-Gm-Message-State: AJIora8J27pjGr8z3PkcAFW56ck50Ebrp8PYyMjGLuFQr9O1v7n9II8c stN1ifsMtg5jJIPuv94zYPj0FsNwsLqDMF7lwPuTSg== X-Google-Smtp-Source: AGRyM1vpjSh9Y05u4DDxMAgxG1Ha5a6O1Yp1CqeRVvx6hQ7LjjtidYeoQ5W9aC0ImR5rk487POkEk9TQdl0wKxfgqfc= X-Received: by 2002:a81:d05:0:b0:317:76a1:9507 with SMTP id 5-20020a810d05000000b0031776a19507mr10201231ywn.151.1656590220853; Thu, 30 Jun 2022 04:57:00 -0700 (PDT) MIME-Version: 1.0 References: <20220628081709.829811-1-colin.foster@in-advantage.com> <20220628081709.829811-4-colin.foster@in-advantage.com> <20220628182535.GC855398@euler> In-Reply-To: From: Linus Walleij Date: Thu, 30 Jun 2022 13:56:49 +0200 Message-ID: Subject: Re: [PATCH v11 net-next 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module To: Andy Shevchenko Cc: Colin Foster , devicetree , Linux Kernel Mailing List , netdev , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Vladimir Oltean , Lee Jones , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lars Povlsen , Steen Hegelund , Microchip Linux Driver Support , Wolfram Sang , Terry Bowman , Florian Fainelli Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2022 at 9:00 PM Andy Shevchenko wrote: > > On Tue, Jun 28, 2022 at 8:25 PM Colin Foster > wrote: > > On Tue, Jun 28, 2022 at 02:53:49PM +0200, Andy Shevchenko wrote: > > > On Tue, Jun 28, 2022 at 10:17 AM Colin Foster > > > wrote: > > ... > > > > > builtin_platform_driver(ocelot_pinctrl_driver); > > > > > > This contradicts the logic behind this change. Perhaps you need to > > > move to module_platform_driver(). (Yes, I think functionally it won't > > > be any changes if ->remove() is not needed, but for the sake of > > > logical correctness...) > > > > I'll do this. Thanks. > > > > Process question: If I make this change is it typical to remove all > > Reviewed-By tags? I assume "yes" > > I would not. This change is logical continuation and I truly believe > every reviewer will agree on it. I would have to think hard to remember a single review comment from Andy where I didn't think "ah, yeah he's right", so definately keep mine. Yours, Linus Walleij