From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1603C4338F for ; Fri, 30 Jul 2021 10:10:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94D8E60E76 for ; Fri, 30 Jul 2021 10:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238515AbhG3KK0 (ORCPT ); Fri, 30 Jul 2021 06:10:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238400AbhG3KKZ (ORCPT ); Fri, 30 Jul 2021 06:10:25 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF2D3C061765 for ; Fri, 30 Jul 2021 03:10:19 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id l17so11642188ljn.2 for ; Fri, 30 Jul 2021 03:10:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sFJWAT6+yMXBU3J+rhlr9bsyK6eGtQ9oxA2zJ2Hz9Us=; b=yacaUotO0pAuhrSnK8U7CsNGg8eT108HSb6UUXyeFRlA1hD2cL8Yx3LsJbhn2jKnRR 40m2ECOdR3mX/RLMjn+N0vksVfdKYEA9m6mweSt8CKk8pH9osHcguKrx+Qk5Si7EuG57 Rv7tYKEExZwBeyCg5DFFStN21IKrCm8ZR5wVu/8MFn8vXS6gCbg3Ud27IA3j+0nIQC3m +RmSdrpycP6z4aVNJSx8K59CP73QrsR3V5CeXRNE+f0cthnm8wFGMdCt+fvFzHmspBJK zd0vV5lSY277z3IxnvAolc4xBIoSLL2G2lWzW+g+j4On5txYMFNI1IuXRYlZEHFqJwcr owBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sFJWAT6+yMXBU3J+rhlr9bsyK6eGtQ9oxA2zJ2Hz9Us=; b=ESGQ/hUC3Rg6kgwUbpz43FDUX8BgXsJ6M9f1k2RMBVxLgpy4yTmM+6N+R39N2wf5NV FrysDj/b39/b+5no4UxQ/0NvVDyzXlSX9OmNGUYYs/BjUvTD3ngsQPZtWcuCtkeLujrF vnfzcwahRuF4f5w1pJSm/IDLrbmCQa3gWLip7/s2Tthfk6lwhAWZXWYFmtEhEYrZ/PVP c89o5RQJmEFOxCmFDkKWBFTAO80VlbwDEYLT/7JY3ZIP7q/D5r5Hi0Wtoaaij/KoMMEv dEViWR71xv+4qeg5yB7AR10zGr5A7ghsljD/GJbQ4j1Ue2dg5ttfiKGysqVTFpgVeWMa ju/A== X-Gm-Message-State: AOAM533XGlu+g8XEfBMgKJUQEtjlJe505udfD69v9KpHUwGnxc848to3 7ZwJpkda0bNSj678rNHcHVQGmivcEuVnNvoqR49jjw== X-Google-Smtp-Source: ABdhPJwuivHtX33drvirx0EUGhFWd7FU9b9FPwibFhbzPtrz6ATn/2Lusr18tOPv36nla21F5HPy85DL4diBaQ2TMPo= X-Received: by 2002:a2e:7c04:: with SMTP id x4mr1152070ljc.273.1627639818222; Fri, 30 Jul 2021 03:10:18 -0700 (PDT) MIME-Version: 1.0 References: <20210717045627.1739959-1-daniel@0x0f.com> <20210717045627.1739959-4-daniel@0x0f.com> In-Reply-To: <20210717045627.1739959-4-daniel@0x0f.com> From: Linus Walleij Date: Fri, 30 Jul 2021 12:10:07 +0200 Message-ID: Subject: Re: [PATCH 03/10] gpio: msc313: Code clean ups To: Daniel Palmer Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-kernel , Rob Herring , Romain Perier Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 17, 2021 at 6:56 AM Daniel Palmer wrote: > - Remove the unneeded assignment of ret before returning it. > - Remove an unneeded blank line > > Signed-off-by: Daniel Palmer Reviewed-by: Linus Walleij Yours, Linus Walleij