From: Linus Walleij <linus.walleij@linaro.org>
To: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-watchdog@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
kernel <kernel@savoirfairelinux.com>,
Rob Herring <robh@kernel.org>, Guenter Roeck <linux@roeck-us.net>,
Fabio Estevam <fabio.estevam@nxp.com>,
Mark Featherston <mark@embeddedarm.com>,
kris@embeddedarm.com, Simon Horman <horms+renesas@verge.net.au>,
Thierry Reding <treding@nvidia.com>,
Jon Hunter <jonathanh@nvidia.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Wim Van Sebroeck <wim@iguana.be>,
Mark Rutland <mark.rutland@arm.com>,
damien.riegel@savoirfairelinux.com,
Lucile Quirion <lucile.quirion@savoirfairelinux.com>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
"Suzuki K. Poulose" <suzuki.poulose@arm.com>,
Will Deacon <will.deacon@arm.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH v2 4/6] bus: add driver for the Technologic Systems NBUS
Date: Tue, 14 Mar 2017 14:23:57 +0100 [thread overview]
Message-ID: <CACRpkdbjANV+kiO_W9+=OL=fzPtTVwH2CpWDmNa50t3JaHTFkQ@mail.gmail.com> (raw)
In-Reply-To: <82dfdbb8-58fc-45b4-685c-98be11341e45@savoirfairelinux.com>
On Wed, Feb 22, 2017 at 5:56 PM, Sebastien Bourdelin
<sebastien.bourdelin@savoirfairelinux.com> wrote:
> On 02/04/2017 05:14 AM, Linus Walleij wrote:
>>> + gpiod_set_array_value_cansleep(gpios->ndescs, gpios->desc, values);
>>
>> This can also fail and you should check the return code and print an error
>> message if it does.
>>
> As far as i understood, the "gpiod_set_array_value_cansleep(...)"
> function doesn't return
> anything, it will return immediately if gpios->desc is null but nothing
> else.
> Did i miss something?
No I did, sorry about that.
We *should* make these functions return errors but currently they do not.
>> Error codes?
>>
> Same question here, these functions only make call to
> "gpiod_set_value_cansleep(...)",
> which as far as i understood doesn't return any error code.
Yeah, forget that.
>>> + gpiod_set_value_cansleep(ts_nbus->csn, 1);
>>
>> Here too.
>>
> Same question, doesn't seem to have an error code.
That too.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-03-14 13:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 19:47 [PATCH v2 0/6] Add board support for TS-4600 Sebastien Bourdelin
2017-02-03 19:47 ` [PATCH v2 1/6] of: documentation: add bindings documentation " Sebastien Bourdelin
2017-03-07 11:48 ` Shawn Guo
2017-02-03 19:47 ` [PATCH v2 2/6] ARM: dts: TS-4600: add basic device tree Sebastien Bourdelin
2017-02-03 19:47 ` [PATCH v2 3/6] dt-bindings: bus: Add documentation for the Technologic Systems NBUS Sebastien Bourdelin
2017-02-08 21:48 ` Rob Herring
2017-02-03 19:47 ` [PATCH v2 4/6] bus: add driver " Sebastien Bourdelin
2017-02-04 10:14 ` Linus Walleij
2017-02-22 16:56 ` Sebastien Bourdelin
2017-03-14 13:23 ` Linus Walleij [this message]
2017-03-14 15:40 ` Sebastien Bourdelin
2017-02-03 19:47 ` [PATCH v2 5/6] ARM: dts: TS-4600: add NBUS support Sebastien Bourdelin
2017-02-03 19:47 ` [PATCH v2 6/6] watchdog: ts4600: add driver for TS-4600 watchdog Sebastien Bourdelin
2017-02-05 0:21 ` [v2,6/6] " Guenter Roeck
2017-02-08 21:50 ` [PATCH v2 6/6] " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbjANV+kiO_W9+=OL=fzPtTVwH2CpWDmNa50t3JaHTFkQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=damien.riegel@savoirfairelinux.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=horms+renesas@verge.net.au \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kernel@savoirfairelinux.com \
--cc=kris@embeddedarm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=lucile.quirion@savoirfairelinux.com \
--cc=mark.rutland@arm.com \
--cc=mark@embeddedarm.com \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=sebastien.bourdelin@savoirfairelinux.com \
--cc=shawnguo@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=treding@nvidia.com \
--cc=will.deacon@arm.com \
--cc=wim@iguana.be \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).