From: Linus Walleij <linus.walleij@linaro.org>
To: Hongwei Zhang <hongweiz@ami.com>
Cc: Andrew Jeffery <andrew@aj.id.au>,
linux-gpio <linux-gpio@vger.kernel.org>,
Joel Stanley <joel@jms.id.au>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [v5 2/2] gpio: aspeed: Add SGPIO driver
Date: Mon, 29 Jul 2019 01:37:33 +0200 [thread overview]
Message-ID: <CACRpkdbkLj7WDMp7vtNDR81yezw-zPq3MWvVRLKvpkvAueo0uw@mail.gmail.com> (raw)
In-Reply-To: <1563827815-15092-1-git-send-email-hongweiz@ami.com>
On Mon, Jul 22, 2019 at 10:37 PM Hongwei Zhang <hongweiz@ami.com> wrote:
> As you suspected it correctly, AST2500 utilizes all the 32 bits of the registers
> (data value, interrupt, etc...), such that using 8-bit bands
> [7:0]/[15:8]/23:16]/[31:24] of GPIO_200H for SGPIO_A/B/C/D .
> so registering 10 gpiochip drivers separately will make code more
> complicated, for example gpio_200 register (data_value reg) has to be
> shared by 4 gpiochip instances, and the same is true for gpio204 (interrupt reg),
> and other more registers.
> So we would prefer to keeping current implementation.
OK this is a pretty good argument. My review assumed one
32-bit register was not shared between banks but it is,
I see.
The above situation can be managed by regmap, but that will
just a different complexity so go with this approach then.
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-07-28 23:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 19:24 [v5 0/2] gpio: aspeed: Add SGPIO driver Hongwei Zhang
2019-07-19 19:24 ` [v5 1/2] dt-bindings: gpio: aspeed: Add SGPIO support Hongwei Zhang
2019-07-20 8:12 ` Linus Walleij
2019-07-22 1:42 ` Andrew Jeffery
2019-07-28 23:34 ` Linus Walleij
2019-07-29 0:19 ` Andrew Jeffery
2019-07-29 21:57 ` Linus Walleij
2019-07-30 19:25 ` Hongwei Zhang
2019-07-19 19:24 ` [v5 2/2] gpio: aspeed: Add SGPIO driver Hongwei Zhang
2019-07-20 7:36 ` Linus Walleij
2019-07-22 20:36 ` Hongwei Zhang
2019-07-28 23:37 ` Linus Walleij [this message]
2019-07-29 20:29 ` [v6 " Hongwei Zhang
2019-07-29 20:43 ` Hongwei Zhang
2019-07-29 20:56 ` [v5 " Hongwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbkLj7WDMp7vtNDR81yezw-zPq3MWvVRLKvpkvAueo0uw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andrew@aj.id.au \
--cc=bgolaszewski@baylibre.com \
--cc=hongweiz@ami.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).