From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754703Ab2HVLPg (ORCPT ); Wed, 22 Aug 2012 07:15:36 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:35139 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753098Ab2HVLPc (ORCPT ); Wed, 22 Aug 2012 07:15:32 -0400 MIME-Version: 1.0 In-Reply-To: <1345564885-11970-1-git-send-email-stigge@antcom.de> References: <1345564885-11970-1-git-send-email-stigge@antcom.de> Date: Wed, 22 Aug 2012 13:15:31 +0200 Message-ID: Subject: Re: [PATCH v5 2/2] spi/pl022: Add devicetree support From: Linus Walleij To: Roland Stigge Cc: aletes.xgr@gmail.com, broonie@opensource.wolfsonmicro.com, grant.likely@secretlab.ca, rob.herring@calxeda.com, rob@landley.net, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, spi-devel-general@lists.sourceforge.net, gabriel.fernandez@stericsson.com, lee.jones@linaro.org, viresh.kumar@linaro.org, sachin.verma@st.co Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 21, 2012 at 6:01 PM, Roland Stigge wrote: > This patch adds device tree support to the spi-pl022 driver. (...) > --- linux-2.6.orig/Documentation/devicetree/bindings/spi/spi_pl022.txt > +++ linux-2.6/Documentation/devicetree/bindings/spi/spi_pl022.txt > @@ -6,7 +6,22 @@ Required properties: > - interrupts : Should contain SPI controller interrupt > > Optional properties: > +- num-cs : total number of chipselects I don't know if it's proper to duplicate but atleast *also* patch Documentation/devicetree/bindings/gpio/gpio.txt to indicate that this is a generic property on all GPIO drivers. The rest looks good. Yours, Linus Walleij