archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <>
To: Nadav Amit <>
Cc: "open list:GPIO SUBSYSTEM" <>,
	"" <>
Subject: Re: [PATCH] gpio: Fix wrong rounding in gpio-menz127
Date: Tue, 12 Jun 2018 10:40:22 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Jun 4, 2018 at 3:58 PM, Nadav Amit <> wrote:

> men_z127_debounce() tries to round up and down, but uses functions which
> are only suitable when the divider is a power of two, which is not the
> case. Use the appropriate ones.
> Found by static check. Compile tested.
> Fixes: f436bc2726c64 ("gpio: add driver for MEN 16Z127 GPIO controller")
> Signed-off-by: Nadav Amit <>

Applied as a non-critical fix as I have not error reports.

Linus Walleij

      reply	other threads:[~2018-06-12  8:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04 13:58 Nadav Amit
2018-06-12  8:40 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \
    --subject='Re: [PATCH] gpio: Fix wrong rounding in gpio-menz127' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).