From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 289CDC33C9E for ; Tue, 7 Jan 2020 09:45:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3A622080A for ; Tue, 7 Jan 2020 09:45:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L7Yekdgj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727752AbgAGJpi (ORCPT ); Tue, 7 Jan 2020 04:45:38 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:39632 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726485AbgAGJph (ORCPT ); Tue, 7 Jan 2020 04:45:37 -0500 Received: by mail-lf1-f68.google.com with SMTP id y1so38388175lfb.6 for ; Tue, 07 Jan 2020 01:45:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T3vugB6Qu+hg8N2SRIaebFbxjQ0rXg7WNTL//JNDGnk=; b=L7YekdgjF3qbrxhKWPnQGcodWPSyCVzxAm1Zp2kbJL+CTc2UiYzlmnpuntqa1ei6Pe Qq2EchUzXxcGdUnHVWtgpSN8yuAv7alGgUzWOnVGYEtnK5ae9zWA+G+RJm2Knshz4GcH vQZmr4ngNwiHPcHWomuop4Kn0rNd+2XiyP4L0PMjNeQO5fkCUZIEJ4eObIl7AgFO09t8 fpKb5PlQaBWquu2sElIJqcU12SP08cKt6ewbzpky6TtoOzyyKRaTTzXd1MLQHtJ5ee0I CJmhTb/mPMy5aHzcf7/0HngijnODPmVaRUFMB0tPX0JoY2Ir0EDQ8sa5WU+0geKvMGlW vk1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T3vugB6Qu+hg8N2SRIaebFbxjQ0rXg7WNTL//JNDGnk=; b=LRZxqrNQUQkPZfB0kELpOgk8C744AmMgsoxFa3L7tS3VUIjMPTY548iic7aAyYKuA+ xHK8haj05+5zEbv47Jsqbt9GUXXpOjOaeJfH8o8dmLbiyzwTU2pZ+WGdcQtHS945hZWx ncBGR+w2y3dFExzZnImX34jROFMRvRp12h1B7Nf3V4+4zJuUYp2hqrw/IeMUGp+ni8vU w4XuiHnrWt/ptV0Q3kIIt0nnCWhFnsPKtaLHmXQzjWe1XJ28MRh36UVpe/6sWN2FLHaK ByM4qtr6kb6yA7uCSihMk4xMbDF1AP8mGbp8d18zx72VVyAOnDWkrnBeZVcvvtn53FWT U9Vw== X-Gm-Message-State: APjAAAV8yRG9PjBABuLQNKTJqfFyDn7wSmRmnsgR1xSGPcc5W3x8jF1E 7OdalicbffP9zZrlRPl8ED4jvZMoUbsL1YZe2MAVGQ== X-Google-Smtp-Source: APXvYqySRirN6OVtQ4D1qwmutDdmHlcunK5AA3Rw93pqwxd0gFUoAfC+0BNom26keyxoOQ7H+ZpYS1n3fqMftps70cU= X-Received: by 2002:ac2:4945:: with SMTP id o5mr58157919lfi.93.1578390334610; Tue, 07 Jan 2020 01:45:34 -0800 (PST) MIME-Version: 1.0 References: <20191218163701.171914-1-arnd@arndb.de> In-Reply-To: <20191218163701.171914-1-arnd@arndb.de> From: Linus Walleij Date: Tue, 7 Jan 2020 10:45:23 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: lochnagar: select GPIOLIB To: Arnd Bergmann Cc: Charles Keepax , Richard Fitzgerald , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , patches@opensource.cirrus.com, "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 18, 2019 at 5:37 PM Arnd Bergmann wrote: > In a rare randconfig build I came across one configuration that does > not enable CONFIG_GPIOLIB, which is needed by lochnagar: > > ERROR: "devm_gpiochip_add_data" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! > ERROR: "gpiochip_generic_free" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! > ERROR: "gpiochip_generic_request" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! > ERROR: "gpiochip_get_data" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! > > Add another 'select' like all other pinctrl drivers have. > > Fixes: 0548448b719a ("pinctrl: lochnagar: Add support for the Cirrus Logic Lochnagar") > Signed-off-by: Arnd Bergmann Patch applied! > I wonder if GPIOLIB should just become mandatory when enabling the pinctrl > subsystem, or if there are still good reasons for leaving it disabled > on any machine that uses CONFIG_PINCTRL. Hm that is a tricky question, they almost always come in pair but are technically speaking separate subsystems. I have a (very) long-term plan to merge them at some point before I retire :D Yours, Linus Walleij