From: Linus Walleij <linus.walleij@linaro.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()
Date: Wed, 1 Feb 2017 14:05:43 +0100 [thread overview]
Message-ID: <CACRpkdbr6BGm3mJ_2XOAuootK-ruibiGsG8=LvKhrz1cpUrnhA@mail.gmail.com> (raw)
In-Reply-To: <20170131204202.7b589ca6@bbrezillon>
On Tue, Jan 31, 2017 at 8:42 PM, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:
> On Tue, 31 Jan 2017 10:39:36 -0800
> Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>> Hmm, yeah, I agree, that would be weird. Then let's leave
>> devm_get_gpiod_from_child() as is ;)
>
> Changing the internal implementation has never been the goal of this
> patch. As explained in the commit log, I'm just renaming the function
> to make it consistent with other fwnode functions (as suggested by
> Linus).
> What's happening here is exactly the kind of discussion I wanted to
> avoid, and the reason I decided to not change the
> devm_get_gpiod_from_child() prototype/name in the first place.
>
> Linus, is this something you really care about? If that's the case, can
> you step in?
I can only throw up my hands... The way I percieved it, a new function
was added, but I guess it could be that the diffstat was so
convoluted in the other patch (by the way that diff sometimes give
very confusing stuff unless you use the right fuzz) so I misunderstood
some other renaming as introducing a new function.
Please drop the patch if it is controversial.
The name of the function *is* confusing though but maybe it's not
the biggest problem in the world.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-02-01 13:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 15:41 [PATCH 0/2] gpio: Add the devm_fwnode_get_index_gpiod_from_child() helper Boris Brezillon
2017-01-30 15:41 ` [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child() Boris Brezillon
2017-01-30 19:57 ` Jacek Anaszewski
2017-01-31 1:06 ` Dmitry Torokhov
2017-01-31 8:04 ` Boris Brezillon
2017-01-31 8:44 ` Dmitry Torokhov
2017-01-31 9:07 ` Boris Brezillon
2017-01-31 9:11 ` Dmitry Torokhov
2017-01-31 9:24 ` Boris Brezillon
2017-01-31 18:39 ` Dmitry Torokhov
2017-01-31 19:42 ` Boris Brezillon
2017-02-01 13:05 ` Linus Walleij [this message]
2017-02-01 13:22 ` Boris Brezillon
2017-02-01 14:51 ` Linus Walleij
2017-02-01 17:18 ` Dmitry Torokhov
2017-02-02 10:07 ` Mika Westerberg
2017-02-01 17:17 ` Dmitry Torokhov
2017-02-02 10:53 ` Linus Walleij
2017-02-02 11:53 ` Boris Brezillon
2017-01-30 15:41 ` [PATCH 2/2] gpio: Add the devm_fwnode_get_index_gpiod_from_child() helper Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbr6BGm3mJ_2XOAuootK-ruibiGsG8=LvKhrz1cpUrnhA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=boris.brezillon@free-electrons.com \
--cc=cooloney@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gnurou@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rpurdie@rpsys.net \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).