From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbcD2JRm (ORCPT ); Fri, 29 Apr 2016 05:17:42 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:33400 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbcD2JRJ (ORCPT ); Fri, 29 Apr 2016 05:17:09 -0400 MIME-Version: 1.0 In-Reply-To: <1461074628-20224-1-git-send-email-ludovic.desroches@atmel.com> References: <1461074628-20224-1-git-send-email-ludovic.desroches@atmel.com> Date: Fri, 29 Apr 2016 11:17:08 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic From: Linus Walleij To: Ludovic Desroches Cc: Nicolas Ferre , Alexandre Belloni , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 19, 2016 at 4:03 PM, Ludovic Desroches wrote: > The default configuration of a pin is often with a value in the > pull-up/down field at chip reset. So, even if the internal logic of the > controller prevents writing a configuration with pull-up and pull-down at > the same time, we must ensure explicitly this condition before writing the > register. > > This was leading to a pull-down condition not taken into account for > instance. > > Signed-off-by: Ludovic Desroches > Fixes: 776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller") > Cc: stable@vger.kernel.org #v4.4 and later Patch applied for fixes with the ACKs. Yours, Linus Walleij