From: Erik Gilling <konkers@android.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
lkml <linux-kernel@vger.kernel.org>,
Maarten Lankhorst <maarten.lankhorst@canonical.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Rob Clark <robclark@gmail.com>,
Sumit Semwal <sumit.semwal@linaro.org>,
dri-devel@lists.freedesktop.org,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 10/30] staging: sync: Export sync API symbols
Date: Fri, 1 Mar 2013 14:47:56 -0800 [thread overview]
Message-ID: <CACSP8SgHCJCZ2S+3NcUXEKg7fdV_LGZ7ZGXhYoMP0yPNc4c5Cg@mail.gmail.com> (raw)
In-Reply-To: <CACSP8Sg=sTbJ_Yv=PdxvHQ--0_rTLN6XG3+0aFKzzHxMzVxKhw@mail.gmail.com>
On Fri, Mar 1, 2013 at 12:21 AM, Erik Gilling <konkers@android.com> wrote:
> On Thu, Feb 28, 2013 at 7:59 PM, John Stultz <john.stultz@linaro.org> wrote:
>> Given its the sync driver, its most obvious choice, but I agree its likely
>> to collide with filesystem related or other sync_ named functions that don't
>> have a subsystem prefix.
>>
>> Any suggestions?
>>
>> The only good alternative I can think of is that in some private
>> conversations with DanielV, he referred to Android using "sync-points".
>>
>> Erik: Would syncpoint_ be an ok prefix? Or do you have other ideas?
>
> syncpoint would be semantically weird when you end up with struct
> syncpoint_pt. I'm open to suggestions as long as it works with
> XXXX_pt, XXXX_timeline, and XXXX_fence. I'll ask around the office
> and see if someone has a good idea.
Colin Cross pointed out that this is limited to sync_fence_*,
sync_pt_*, and sync_timeline_* and not sync_* so it's much less likely
to have naming collisions.
Cheers,
Erik
next prev parent reply other threads:[~2013-03-01 22:48 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 0:42 [RFC][PATCH 00/30] staging: Android sync driver John Stultz
2013-03-01 0:42 ` [PATCH 01/30] staging: sync: Add synchronization framework John Stultz
2013-03-01 0:42 ` [PATCH 02/30] staging: sw_sync: Add cpu based sync driver John Stultz
2013-03-01 0:42 ` [PATCH 03/30] staging: sync: Add timestamps to sync_pts John Stultz
2013-03-01 0:43 ` [PATCH 04/30] staging: sync: Add debugfs support John Stultz
2013-03-01 0:43 ` [PATCH 05/30] staging: sw_sync: Add debug support John Stultz
2013-03-01 0:43 ` [PATCH 06/30] staging: sync: Add ioctl to get fence data John Stultz
2013-03-01 0:43 ` [PATCH 07/30] staging: sw_sync: Add fill_driver_data support John Stultz
2013-03-01 0:43 ` [PATCH 08/30] staging: sync: Add poll support John Stultz
2013-03-01 0:43 ` [PATCH 09/30] staging: sync: Allow async waits to be canceled John Stultz
2013-03-01 0:43 ` [PATCH 10/30] staging: sync: Export sync API symbols John Stultz
2013-03-01 2:00 ` Greg KH
2013-03-01 3:59 ` John Stultz
2013-03-01 8:21 ` Erik Gilling
2013-03-01 13:55 ` Greg KH
2013-03-01 16:30 ` Erik Gilling
2013-03-01 22:47 ` Erik Gilling [this message]
2013-03-01 0:43 ` [PATCH 11/30] staging: sw_sync: Export sw_sync API John Stultz
2013-03-01 0:43 ` [PATCH 12/30] staging: sync: Reorder sync_fence_release John Stultz
2013-03-01 0:43 ` [PATCH 13/30] staging: sync: Optimize fence merges John Stultz
2013-03-01 0:43 ` [PATCH 14/30] staging: sync: Add internal refcounting to fences John Stultz
2013-03-01 0:43 ` [PATCH 15/30] staging: sync: Add reference counting to timelines John Stultz
2013-03-01 0:43 ` [PATCH 16/30] staging: sync: Fix error paths John Stultz
2013-03-01 0:43 ` [PATCH 17/30] staging: sw_sync: " John Stultz
2013-03-01 0:43 ` [PATCH 18/30] staging: sync: Change wait timeout to mirror poll semantics John Stultz
2013-03-01 0:43 ` [PATCH 19/30] staging: sync: Dump sync state to console on timeout John Stultz
2013-03-01 0:43 ` [PATCH 20/30] staging: sync: Improve timeout dump messages John Stultz
2013-03-01 0:43 ` [PATCH 21/30] staging: sync: Dump sync state on fence errors John Stultz
2013-03-01 0:43 ` [PATCH 22/30] staging: sync: Protect unlocked access to fence status John Stultz
2013-03-01 0:43 ` [PATCH 23/30] staging: sync: Update new fence status with sync_fence_signal_pt John Stultz
2013-03-01 0:43 ` [PATCH 24/30] staging: sync: Use proper barriers when waiting indefinitely John Stultz
2013-03-01 0:43 ` [PATCH 25/30] staging: sync: Refactor sync debug printing John Stultz
2013-03-01 0:43 ` [PATCH 26/30] staging: sw_sync: Convert to use new value_str debug ops John Stultz
2013-03-01 0:43 ` [PATCH 27/30] staging: sync: Add tracepoint support John Stultz
2013-03-01 0:43 ` [PATCH 28/30] staging: sync: Fix race condition between merge and signal John Stultz
2013-03-01 0:43 ` [PATCH 29/30] staging: sync: Don't log wait timeouts when timeout = 0 John Stultz
2013-03-01 0:43 ` [PATCH 30/30] staging: sync: Fix timeout = 0 wait behavior John Stultz
2013-03-01 1:59 ` [RFC][PATCH 00/30] staging: Android sync driver Greg KH
2013-03-01 16:20 ` Erik Gilling
2013-03-03 18:42 ` Daniel Vetter
2013-03-03 18:52 ` animelovin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACSP8SgHCJCZ2S+3NcUXEKg7fdV_LGZ7ZGXhYoMP0yPNc4c5Cg@mail.gmail.com \
--to=konkers@android.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=robclark@gmail.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).