From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24635C2D0C0 for ; Thu, 19 Dec 2019 10:49:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA12B21D7D for ; Thu, 19 Dec 2019 10:49:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="W54SHQ5d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbfLSKth (ORCPT ); Thu, 19 Dec 2019 05:49:37 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:38457 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbfLSKtg (ORCPT ); Thu, 19 Dec 2019 05:49:36 -0500 Received: by mail-qk1-f194.google.com with SMTP id k6so4263817qki.5 for ; Thu, 19 Dec 2019 02:49:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=deId2JVQ12jlGeQHYsi9LkbuFlqPgIP/ixlZ7XgRV7I=; b=W54SHQ5dlTm6SThWjY6Bc5SCBNejl/zWftJRnsauXNSyNMSdUA2HX7Q9hbbKpOmyE6 lBPZXrRNUT0G5Dhea3G7dyDt5gVpYE4CknR0ofVlj+TBFuiqi5w/Ox2hX93OkAzwWewx zlY1BmrW997a+ZNGk4lECZBdofKldism9dtxUfd3bOZfPKfLioHTJAQ26aCJMicC/4z5 ijuY7OAnvYvCoG/VgM39BURMYHeO1cPruRHJIOqPhXqbpsfGPv9rHQzMglUx/cAu+F4j k6FFeRNotAB9W0Ae3zjq5eg6nvI1JwAFmxtBAsObUEtiYfu30ehBlm4FXWc/tOtMHfJp CI7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=deId2JVQ12jlGeQHYsi9LkbuFlqPgIP/ixlZ7XgRV7I=; b=YjAldQsEQ2CVS/mZHAuKrrw7JrC1fsKr7kpGSZxX06uQ6l+VEwPoSZl1s8K9slqLbz qC/cApJF0lp/vrruSXIRDGHyYhur7Yt6Jntfb9BP5M9sCRx6JLvPMbpjsERg2K3pWV4J wo8FzE/GeTQ3XzS41jAhSvPvN/Xj1zflTnHgkbGiLzKi5/OODyLDuyvF3c6gMXTeKwd+ fbJ0CoOU2VOF/TyWp3Eu3lUTGhO2/LYPwvt0vFZBqjQ+Mfqc69wAPR9ZZBBvS6kxfRMS JzKo2EJshy6VUBxqJIWY+0+qE6/vTJzYLpz5UyACYJfVUt32hYs+MsfIB9gzN5kJNTCW nxqQ== X-Gm-Message-State: APjAAAWiG22h8dvE8p4gwrlUE6XQ2sr5e1al/uypvcMbsuMM/wybhbin 7LP2sJavB4A7aj605Wp7vFRoSVBoHUfVoF0w/isJbg== X-Google-Smtp-Source: APXvYqzwhtA5yupYMnkUb/LMNdluvQ09zvtZWL+0pPgsXyWCWFF/OnGQd/gYwoadTMrw8erMOsfI9zjM4+SudhHRHf0= X-Received: by 2002:ae9:eb48:: with SMTP id b69mr7186389qkg.43.1576752574661; Thu, 19 Dec 2019 02:49:34 -0800 (PST) MIME-Version: 1.0 References: <20191208232734.225161-1-Jason@zx2c4.com> In-Reply-To: From: Dmitry Vyukov Date: Thu, 19 Dec 2019 11:49:23 +0100 Message-ID: Subject: Re: [PATCH net-next v2] net: WireGuard secure network tunnel To: "Jason A. Donenfeld" Cc: netdev , LKML , David Miller , Greg KH , Linus Torvalds , Herbert Xu , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 19, 2019 at 11:11 AM Jason A. Donenfeld wrote: > > On Thu, Dec 19, 2019 at 11:07 AM Jason A. Donenfeld wrote: > > > > On Thu, Dec 19, 2019 at 10:35 AM Dmitry Vyukov wrote: > > That's exciting about syzcaller having at it with WireGuard. Is there > > some place where I can "see" it fuzzing WireGuard, or do I just wait > > for the bug reports to come rolling in? > > Ahh, found it: https://storage.googleapis.com/syzkaller/cover/ci-upstream-net-kasan-gce.html > Looks like we're at 1% and counting. :) Yes, that's it. But that's mostly stray coverage. wg_netdevice_notification I guess mostly because it tested _other_ device types. And a bit of netlink because it sends random garbage into netlink. For netlink part it would require something along these lines: https://github.com/google/syzkaller/blob/master/sys/linux/socket_netlink_generic_devlink.txt https://github.com/google/syzkaller/blob/master/sys/linux/socket_netlink_crypto.txt https://github.com/google/syzkaller/blob/master/sys/linux/socket_netlink_generic_fou.txt https://github.com/google/syzkaller/blob/master/sys/linux/socket_netlink_generic_seg6.txt And for device setup, harder to say. Either pre-create one here: https://github.com/google/syzkaller/blob/79b211f74b08737aeb4934c6ff69a263b3c38013/executor/common_linux.h#L668 or teach it how to create them on the fly or both or something else. Probably some wire packet formats here: https://github.com/google/syzkaller/blob/79b211f74b08737aeb4934c6ff69a263b3c38013/sys/linux/vnet.txt