From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7859C43381 for ; Fri, 15 Feb 2019 15:40:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91D5421A4C for ; Fri, 15 Feb 2019 15:40:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NwkDGDYT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733017AbfBOPkI (ORCPT ); Fri, 15 Feb 2019 10:40:08 -0500 Received: from mail-it1-f196.google.com ([209.85.166.196]:32931 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728226AbfBOPkH (ORCPT ); Fri, 15 Feb 2019 10:40:07 -0500 Received: by mail-it1-f196.google.com with SMTP id g137so8020385ita.0 for ; Fri, 15 Feb 2019 07:40:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pwiEuTnZixZKSv+3Lb9kwYw7YS3/+Y0WOT967+oeM8M=; b=NwkDGDYTek62BzE5nintHbuzA+ahPKj1dwDWWLw1sQ58+Q550Q5IIxyrMPvUQbZ3sQ Z5hGyrGUczI80SQ4M4LN7QVdvsGvbhHiKuripxHz5vpcpll2sqGiFhZEbWQvgMFgv2B+ HrvPOmA5hQ0EorEHpEHgWC6duh7TCVq+gh0so1kbrH8REqFIh4dVCbYnhtXoJJfgOfMU ftOAIIiz85iRM5DjTivbWEzyY0Hc5yhDHNsh512YSj5bMzwBNq9Ll5fDVLbmFu2tv1ic ed5PN5d82RfLDGyxupdhXkBj1roqpmgGv+8uymJHYxOW01h71KBbJOrvKv/UyTQ8DONb It/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pwiEuTnZixZKSv+3Lb9kwYw7YS3/+Y0WOT967+oeM8M=; b=SvQSArXG+ehKEuf04fSsTlaOejH+chWNBjhK8/TnKZJ3UTJSlr9jehS1WusMM+gMgb oMY880h70uKexN8uGjhxwYbGc/mgyILqdj3MRyTdG4OLSRYmn5n74hKcWMZzlK8sQ/hH MOglVuANHBz5bsH89Agu7jfYY2919CeJXJ4WCvKpZ6dUyUQ+rdgONeH1mAW1XFGyw17W IzCpdKQQjq3yg22p6V4IUxaaanRft14/hp5l8JGd3DwP4dso2YT7LOYPvbOYoVOWCciy o8gnvFgSpaPsjifORi7LbxELpvmLts65dDPLTBHwUWUyWQ1nM8YAM9eC7iBP/RIQWPe6 d2fw== X-Gm-Message-State: AHQUAuYo37BDBV4cK9Z4ySRrJf/V73pk3QcpRJMfnuKCtUrmSkl9uzyO 4OQ+dDLQHjrf850iglqRJh6d98baBb+51FvMHeC52Q== X-Google-Smtp-Source: AHgI3IblgLMPn0KEmiVlKPTuU2VNPE26I/KpWjN8yoC/F41GO0aY846WXAEYXl3XQEHh7hiD5RnGz/zsQAio46BaqKU= X-Received: by 2002:a05:660c:3ce:: with SMTP id c14mr4713138itl.166.1550245206243; Fri, 15 Feb 2019 07:40:06 -0800 (PST) MIME-Version: 1.0 References: <000000000000c13ce50577db36cc@google.com> <073dedee-62df-9c67-1742-8de1e6c9502a@redhat.com> In-Reply-To: <073dedee-62df-9c67-1742-8de1e6c9502a@redhat.com> From: Dmitry Vyukov Date: Fri, 15 Feb 2019 16:39:52 +0100 Message-ID: Subject: Re: WARNING: refcount bug in kvm_vm_ioctl To: Paolo Bonzini , Jann Horn Cc: syzbot , KVM list , LKML , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , syzkaller-bugs , Christoffer Dall , Janosch Frank , Christian Borntraeger Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 11, 2018 at 4:18 PM Paolo Bonzini wrote: > > On 10/10/2018 09:58, syzbot wrote: > > do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:316 > > invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:993 > > RIP: 0010:refcount_inc_checked+0x5d/0x70 lib/refcount.c:153 > > kvm_get_kvm arch/x86/kvm/../../../virt/kvm/kvm_main.c:766 [inline] > > kvm_ioctl_create_device arch/x86/kvm/../../../virt/kvm/kvm_main.c:2924 > > kvm_vm_ioctl+0xed7/0x1d40 arch/x86/kvm/../../../virt/kvm/kvm_main.c:3114 > > vfs_ioctl fs/ioctl.c:46 [inline] > > file_ioctl fs/ioctl.c:501 [inline] > > do_vfs_ioctl+0x1de/0x1720 fs/ioctl.c:685 > > ksys_ioctl+0xa9/0xd0 fs/ioctl.c:702 > > __do_sys_ioctl fs/ioctl.c:709 [inline] > > __se_sys_ioctl fs/ioctl.c:707 [inline] > > __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:707 > > do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290 > > entry_SYSCALL_64_after_hwframe+0x49/0xbe > > The trace here is fairly simple, but I don't understand how this could > happen. > > The kvm_get_kvm is done within kvm_ioctl_create_device, which is called > from ioctl; the last reference cannot disappear inside a ioctl, because: > > 1) kvm_ioctl is called from vfs_ioctl, which does fdget and holds the fd > reference until after kvm_vm_ioctl returns > > 2) the file descriptor holds one reference to the struct kvm*, and this > reference is not released until kvm_vm_release is called by the last > fput (which could be fdput's call to fput if the process has exited in > the meanwhile) > > 3) for completeness, in case anon_inode_getfd fails, put_unused_fd will > not invoke the file descriptor's ->release callback (in this case > kvm_device_release). > > CCing some random people to get their opinion... > > Paolo Jann, is it what you fixed in "kvm: fix kvm_ioctl_create_device() reference counting (CVE-2019-6974)"? If so, we need to close the syzbot bug. > > # See https://goo.gl/kgGztJ for information about syzkaller reproducers. > > #{"threaded":true,"collide":true,"repeat":true,"procs":6,"sandbox":"none","fault_call":-1,"tun":true,"tmpdir":true,"cgroups":true,"netdev":true,"resetnet":true,"segv":true} > > r0 = openat$kvm(0xffffffffffffff9c, &(0x7f0000000380)='/dev/kvm\x00', 0x0, 0x0) > > r1 = syz_open_dev$dspn(&(0x7f0000000100)='/dev/dsp#\x00', 0x3fe, 0x400) > > r2 = ioctl$KVM_CREATE_VM(r0, 0xae01, 0x0) > > perf_event_open(&(0x7f0000000040)={0x1, 0x70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x50d}, 0x0, 0xffffffffffffffff, 0xffffffffffffffff, 0x0) > > mincore(&(0x7f0000ffc000/0x1000)=nil, 0x1000, &(0x7f00000003c0)=""/4096) > > setrlimit(0x0, &(0x7f0000000000)) > > readahead(r1, 0x3, 0x9a6) > > ioctl$KVM_CREATE_DEVICE(r2, 0xc00caee0, &(0x7f00000002c0)={0x4}) > > setsockopt$inet_sctp6_SCTP_FRAGMENT_INTERLEAVE(r1, 0x84, 0x12, &(0x7f00000001c0)=0x9, 0x4)