From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A05BC43381 for ; Tue, 12 Mar 2019 08:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D29B214AE for ; Tue, 12 Mar 2019 08:21:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="p75wBFIH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727602AbfCLIVX (ORCPT ); Tue, 12 Mar 2019 04:21:23 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:39026 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726842AbfCLIVX (ORCPT ); Tue, 12 Mar 2019 04:21:23 -0400 Received: by mail-io1-f65.google.com with SMTP id x3so1314021ior.6 for ; Tue, 12 Mar 2019 01:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vY+3ao+y9L7nD7alFgZQuTM3dt7AhOxf+8CD5umNl0c=; b=p75wBFIHduU46nnfX3PfWxgXHU2UczcSHLsci5PTd8pJOinphS+mafVJFXZFS8m/Ru zZwI/MP8R/Fwi6XB98c0v5dyaJu+rcRcd0kc6v3a+uvdxjp6TlYZEW4q5Vp1NaNQWu9s C/0UzZqn/Ho8FLMWRcOY6fX07N7kO932r37SZHcPEUf+/v6q/6vBhoSJMDl9VEOy9A/t sWer/CTS/NWUv7+1NArnXf1IxjP7yE6iUt19VkzghtAOTwgM/9fzrF5u/9UyWWWv+528 9Lg9zIx+2v07rQ3oHt2yEkcagd2WRmXaCEW+lT0fUDE4x7Bi5K/DcbS8WdKyYFFUTyKE GyYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vY+3ao+y9L7nD7alFgZQuTM3dt7AhOxf+8CD5umNl0c=; b=LC0oQGW4mlAIS3zstREaT1T7vFDs++LgxGM2wCfuoEVxn09jS55JZykmqUhTid2EPZ fcdUgTQgNttd5vrP3+vPU1XzbkDqGLtPHA8jv1ggFuphi687okMWSpSzMqqeF5lJxDcg UwUz2YukBQzMZFgelUTN0+ZzelMt8rsDA5F84KKjyeniRcGTSlEO0R+txvvmrJx5ivF0 gPECfl9aKhhMR7MV+raqRmWtMK219NzZ9/oJsW0Sxt00AP/5/r3ABI3I3iZrhA3JhqY1 7tEO0Ug76Ox9EFjB93T+PmWy3cMiY34VMXUAUf4TsQhdhq7+C8cBr5YKaJTxYzxlsjXp aemQ== X-Gm-Message-State: APjAAAUbqxnSC97qF5KvJxGJY+oErREwfPBas/3Bh5qtuUzfT9aO3062 ULMvfpO1UQmtRx3dSkNgjze7iROnevB0G/RXZnVyag== X-Google-Smtp-Source: APXvYqzAI+mcRf6cMfD+a+5cYvDqkAxUok6YQaU5YwpY3W70rbzad3FzsvWAXwjPwuejuQ76x1M4ZAckN9dTUbr+ksk= X-Received: by 2002:a6b:3709:: with SMTP id e9mr9896355ioa.282.1552378881687; Tue, 12 Mar 2019 01:21:21 -0700 (PDT) MIME-Version: 1.0 References: <0000000000001fd5780583d1433f@google.com> <20190311163747.f56cceebd9c2661e4519bdfc@linux-foundation.org> <20190311232541.db8571d2e3e0ca636785f31f@linux-foundation.org> <20190312064300.GB9123@sol.localdomain> In-Reply-To: <20190312064300.GB9123@sol.localdomain> From: Dmitry Vyukov Date: Tue, 12 Mar 2019 09:21:09 +0100 Message-ID: Subject: Re: KASAN: null-ptr-deref Read in reclaim_high To: Eric Biggers Cc: Andrew Morton , syzbot , cgroups@vger.kernel.org, Johannes Weiner , LKML , Linux-MM , Michal Hocko , Michal Hocko , Stephen Rothwell , Shakeel Butt , syzkaller-bugs , Vladimir Davydov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 12, 2019 at 7:43 AM Eric Biggers wrote: > > On Mon, Mar 11, 2019 at 11:25:41PM -0700, Andrew Morton wrote: > > On Tue, 12 Mar 2019 07:08:38 +0100 Dmitry Vyukov wrote: > > > > > On Tue, Mar 12, 2019 at 12:37 AM Andrew Morton > > > wrote: > > > > > > > > On Mon, 11 Mar 2019 06:08:01 -0700 syzbot wrote: > > > > > > > > > syzbot has bisected this bug to: > > > > > > > > > > commit 29a4b8e275d1f10c51c7891362877ef6cffae9e7 > > > > > Author: Shakeel Butt > > > > > Date: Wed Jan 9 22:02:21 2019 +0000 > > > > > > > > > > memcg: schedule high reclaim for remote memcgs on high_work > > > > > > > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=155bf5db200000 > > > > > start commit: 29a4b8e2 memcg: schedule high reclaim for remote memcgs on.. > > > > > git tree: linux-next > > > > > final crash: https://syzkaller.appspot.com/x/report.txt?x=175bf5db200000 > > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=135bf5db200000 > > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=611f89e5b6868db > > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=fa11f9da42b46cea3b4a > > > > > userspace arch: amd64 > > > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14259017400000 > > > > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=141630a0c00000 > > > > > > > > > > Reported-by: syzbot+fa11f9da42b46cea3b4a@syzkaller.appspotmail.com > > > > > Fixes: 29a4b8e2 ("memcg: schedule high reclaim for remote memcgs on > > > > > high_work") > > > > > > > > The following patch > > > > memcg-schedule-high-reclaim-for-remote-memcgs-on-high_work-v3.patch > > > > might have fixed this. Was it applied? > > > > > > Hi Andrew, > > > > > > You mean if the patch was applied during the bisection? > > > No, it wasn't. Bisection is very specifically done on the same tree > > > where the bug was hit. There are already too many factors that make > > > the result flaky/wrong/inconclusive without changing the tree state. > > > Now, if syzbot would know about any pending fix for this bug, then it > > > would not do the bisection at all. But it have not seen any patch in > > > upstream/linux-next with the Reported-by tag, nor it received any syz > > > fix commands for this bugs. Should have been it aware of the fix? How? > > > > memcg-schedule-high-reclaim-for-remote-memcgs-on-high_work-v3.patch was > > added to linux-next on Jan 10. I take it that this bug was hit when > > testing the entire linux-next tree, so we can assume that > > memcg-schedule-high-reclaim-for-remote-memcgs-on-high_work-v3.patch > > does not fix it, correct? > > > > In which case, over to Shakeel! > > > > I don't understand what happened here. First, the syzbot report doesn't say > which linux-next version was tested (which it should), but I get: > > $ git tag --contains 29a4b8e275d1f10c51c7891362877ef6cffae9e7 > next-20190110 > next-20190111 > next-20190114 > next-20190115 > next-20190116 > > That's almost 2 months old, yet this bug was just reported now. Why? Hi Eric, This bug was reported on Jan 10: https://syzkaller.appspot.com/bug?extid=fa11f9da42b46cea3b4a https://groups.google.com/forum/#!msg/syzkaller-bugs/5YkhNUg2PFY/4-B5M7bDCAAJ The start revision of the bisection process (provided) is the same that was used to create the reproducer. The end revision and bisection log are provided in the email. How can we improve the format to make it more clear?