From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D207C8450F for ; Mon, 16 Nov 2020 12:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B353F22265 for ; Mon, 16 Nov 2020 12:38:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dwCtwSG1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730018AbgKPMT0 (ORCPT ); Mon, 16 Nov 2020 07:19:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727027AbgKPMTZ (ORCPT ); Mon, 16 Nov 2020 07:19:25 -0500 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7155DC0613CF for ; Mon, 16 Nov 2020 04:19:25 -0800 (PST) Received: by mail-qt1-x842.google.com with SMTP id t5so12645734qtp.2 for ; Mon, 16 Nov 2020 04:19:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/kYjKHOYdbRkTjeegvgMiUR7lrALhGYE7BaLrgneuEo=; b=dwCtwSG1CRtiWFQFZf4fc7QGzmXHSvCxOczUoTS3liWWSeYKySIjb/aNGCMq4vY22z 7S8yG5Hc/Y57cokBs7emePi+zUY6Vf4tLiP3n+dQ+1A6XDOXo5kMf8IWsTzgmGeyBwii wPbPS5Tc8whp73gFMP0tYWZz4kkggygE6KzTRx19J9eA1MBhSUplPG4LIzTI1Uoo0uDw 8Dcn2aB22UdbhjlGkyV5YM0xI7oTIh8zakc6xXl5vQoJepGLlBGmOnV1cG/3LEt6LX8l sIiLdq0+kAHl85li03YQk/T7Vc7n/pg/nIp8HcVUYieU4VObKtdnd0WxyXWN7am+eLcT oJ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/kYjKHOYdbRkTjeegvgMiUR7lrALhGYE7BaLrgneuEo=; b=kqFTUWR3iAlbW7UxpgAPdcQm1K1NppV9Ke2ODTDndmuzWGhDzcJiQOPwEOEhpHZA+m 3h/vms4MSKLo2VgytqSCkafmFUYtKWG3/bGoPq+Bk85JL8A5ms4TvEIAy7oKWuombLKU zFC1x3JJTbd/Z7nyMRlE2J0eHMFeJnKlBrW3BxKaj6WtlpeGbsDLtSTKz7243dNY6tNB JYwQpzGgpOq7T2VZa8dE9BPiKhRQZgPnAOzFkpawUOaKFA2EegU8N7xjjmzWXpelqCan apjIVBC6Tq8APFvOa/QZSCkVg16uPfdQ0Hn8fdiXaXmcA/IGPykgglzFTAA0cJyoSSH6 br6A== X-Gm-Message-State: AOAM532458DGwah9F9D3wvCoPKskZITkR/oPGA1BdOA/TZb1ncsrXIVu jE0rl3yrjE+rAtIvus83lE9HmJr7DTdjCVO27/lEew== X-Google-Smtp-Source: ABdhPJzVtuVEKbYpXTvA7bt6Bpfm8IWTKWQYpOD+OfdF3VKnQMbyBfE5Xwk1DVVV2nhzbJJ3JbrNZnq9kHaQ20TpoxA= X-Received: by 2002:aed:2744:: with SMTP id n62mr14165891qtd.67.1605529158914; Mon, 16 Nov 2020 04:19:18 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dmitry Vyukov Date: Mon, 16 Nov 2020 13:19:07 +0100 Message-ID: Subject: Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK To: Catalin Marinas Cc: Marco Elver , Andrey Konovalov , Will Deacon , Vincenzo Frascino , Alexander Potapenko , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 16, 2020 at 1:16 PM Catalin Marinas wrote: > > On Mon, Nov 16, 2020 at 12:50:00PM +0100, Marco Elver wrote: > > On Mon, 16 Nov 2020 at 11:59, Dmitry Vyukov wrote: > > > On Thu, Oct 29, 2020 at 8:57 PM 'Andrey Konovalov' via kasan-dev > > > wrote: > > > > On Tue, Oct 27, 2020 at 1:44 PM Dmitry Vyukov wrote: > > > > > > > > > > On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > > > > > > > > > > > There's a config option CONFIG_KASAN_STACK that has to be enabled for > > > > > > KASAN to use stack instrumentation and perform validity checks for > > > > > > stack variables. > > > > > > > > > > > > There's no need to unpoison stack when CONFIG_KASAN_STACK is not enabled. > > > > > > Only call kasan_unpoison_task_stack[_below]() when CONFIG_KASAN_STACK is > > > > > > enabled. > > > > > > > > > > > > Signed-off-by: Andrey Konovalov > > > > > > Link: https://linux-review.googlesource.com/id/If8a891e9fe01ea543e00b576852685afec0887e3 > > > > > > --- > > > > > > arch/arm64/kernel/sleep.S | 2 +- > > > > > > arch/x86/kernel/acpi/wakeup_64.S | 2 +- > > > > > > include/linux/kasan.h | 10 ++++++---- > > > > > > mm/kasan/common.c | 2 ++ > > > > > > 4 files changed, 10 insertions(+), 6 deletions(-) > > > > > > > > > > > > diff --git a/arch/arm64/kernel/sleep.S b/arch/arm64/kernel/sleep.S > > > > > > index ba40d57757d6..bdadfa56b40e 100644 > > > > > > --- a/arch/arm64/kernel/sleep.S > > > > > > +++ b/arch/arm64/kernel/sleep.S > > > > > > @@ -133,7 +133,7 @@ SYM_FUNC_START(_cpu_resume) > > > > > > */ > > > > > > bl cpu_do_resume > > > > > > > > > > > > -#ifdef CONFIG_KASAN > > > > > > +#if defined(CONFIG_KASAN) && CONFIG_KASAN_STACK > > > > > > mov x0, sp > > > > > > bl kasan_unpoison_task_stack_below > > > > > > #endif > > > > > > diff --git a/arch/x86/kernel/acpi/wakeup_64.S b/arch/x86/kernel/acpi/wakeup_64.S > > > > > > index c8daa92f38dc..5d3a0b8fd379 100644 > > > > > > --- a/arch/x86/kernel/acpi/wakeup_64.S > > > > > > +++ b/arch/x86/kernel/acpi/wakeup_64.S > > > > > > @@ -112,7 +112,7 @@ SYM_FUNC_START(do_suspend_lowlevel) > > > > > > movq pt_regs_r14(%rax), %r14 > > > > > > movq pt_regs_r15(%rax), %r15 > > > > > > > > > > > > -#ifdef CONFIG_KASAN > > > > > > +#if defined(CONFIG_KASAN) && CONFIG_KASAN_STACK > > > > > > /* > > > > > > * The suspend path may have poisoned some areas deeper in the stack, > > > > > > * which we now need to unpoison. > > > > > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > > > > > > index 3f3f541e5d5f..7be9fb9146ac 100644 > > > > > > --- a/include/linux/kasan.h > > > > > > +++ b/include/linux/kasan.h > > > > > > @@ -68,8 +68,6 @@ static inline void kasan_disable_current(void) {} > > > > > > > > > > > > void kasan_unpoison_memory(const void *address, size_t size); > > > > > > > > > > > > -void kasan_unpoison_task_stack(struct task_struct *task); > > > > > > - > > > > > > void kasan_alloc_pages(struct page *page, unsigned int order); > > > > > > void kasan_free_pages(struct page *page, unsigned int order); > > > > > > > > > > > > @@ -114,8 +112,6 @@ void kasan_restore_multi_shot(bool enabled); > > > > > > > > > > > > static inline void kasan_unpoison_memory(const void *address, size_t size) {} > > > > > > > > > > > > -static inline void kasan_unpoison_task_stack(struct task_struct *task) {} > > > > > > - > > > > > > static inline void kasan_alloc_pages(struct page *page, unsigned int order) {} > > > > > > static inline void kasan_free_pages(struct page *page, unsigned int order) {} > > > > > > > > > > > > @@ -167,6 +163,12 @@ static inline size_t kasan_metadata_size(struct kmem_cache *cache) { return 0; } > > > > > > > > > > > > #endif /* CONFIG_KASAN */ > > > > > > > > > > > > +#if defined(CONFIG_KASAN) && CONFIG_KASAN_STACK > > > > > > > > > > && defined(CONFIG_KASAN_STACK) for consistency > > > > > > > > CONFIG_KASAN_STACK is different from other KASAN configs. It's always > > > > defined, and its value is what controls whether stack instrumentation > > > > is enabled. > > > > > > Not sure why we did this instead of the following, but okay. > > > > > > config KASAN_STACK > > > - int > > > - default 1 if KASAN_STACK_ENABLE || CC_IS_GCC > > > - default 0 > > > + bool > > > + default y if KASAN_STACK_ENABLE || CC_IS_GCC > > > + default n > > > > I wondered the same, but then looking at scripts/Makefile.kasan I > > think it's because we directly pass it to the compiler: > > ... > > $(call cc-param,asan-stack=$(CONFIG_KASAN_STACK)) \ > > ... > > Try this instead: > > $(call cc-param,asan-stack=$(if $(CONFIG_KASAN_STACK),1,0)) \ We could have just 1 config instead of 2 as well. For gcc we could do no prompt and default value y, and for clang -- prompt and default value n. I think it should do what we need.