From: Dmitry Vyukov <dvyukov@google.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Kirill Tkhai <ktkhai@virtuozzo.com>,
Ingo Molnar <mingo@kernel.org>,
syzbot <syzbot+6b495100f17ca8554ab9@syzkaller.appspotmail.com>,
David Miller <davem@davemloft.net>,
David Herrmann <dh.herrmann@gmail.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
David Windsor <dwindsor@gmail.com>,
"Reshetova, Elena" <elena.reshetova@intel.com>,
Hans Liljestrand <ishkamiel@gmail.com>,
Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Matthew Dawson <matthew@mjdsystems.ca>,
Mateusz Jurczyk <mjurczyk@google.com>,
netdev <netdev@vger.kernel.org>,
syzkaller-bugs@googlegroups.com,
Al Viro <viro@zeniv.linux.org.uk>,
xemul@virtuozzo.com
Subject: Re: possible deadlock in skb_queue_tail
Date: Wed, 4 Apr 2018 21:00:16 +0200 [thread overview]
Message-ID: <CACT4Y+aRqG8i1WUKAF925aqN9Nrg43YE1AjGzzLC5hZs4ZawDw@mail.gmail.com> (raw)
In-Reply-To: <CAM_iQpV89LRuJovA840T0pUQYXkZvecezLmg6=Hp0PxfziOxUQ@mail.gmail.com>
On Wed, Apr 4, 2018 at 7:08 AM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> On Tue, Apr 3, 2018 at 4:42 AM, Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
>> On 03.04.2018 14:25, Dmitry Vyukov wrote:
>>> On Tue, Apr 3, 2018 at 11:50 AM, Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
>>>> sk_diag_dump_icons() dumps only sockets in TCP_LISTEN state.
>>>> TCP_LISTEN state may be assigned in only place in net/unix/af_unix.c:
>>>> it's unix_listen(). The function is applied to stream and seqpacket
>>>> socket types.
>>>>
>>>> It can't be stream because of the second stack, and seqpacket also can't,
>>>> as I don't think it's possible for gcc to inline unix_seqpacket_sendmsg()
>>>> in the way, we don't see it in the stack.
>>>>
>>>> So, this is looks like false positive result for me.
>>>>
>>>> Kirill
>>>
>>> Do you mean that these &(&u->lock)->rlock/1 referenced in 2 stacks are
>>> always different?
>>
>> In these 2 particular stacks they have to be different.
>
> So actually my patch could fix this false positive? I thought it couldn't.
> https://patchwork.ozlabs.org/patch/894342/
You know better!
If you suspect it can fix this report, and nobody has better
proposals, then we can just mark this as being fixed with your commit
and then see if it triggers again with your commit or not.
prev parent reply other threads:[~2018-04-04 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 9:20 possible deadlock in skb_queue_tail syzbot
2018-04-03 9:50 ` Kirill Tkhai
2018-04-03 11:25 ` Dmitry Vyukov
2018-04-03 11:42 ` Kirill Tkhai
2018-04-04 5:08 ` Cong Wang
2018-04-04 19:00 ` Dmitry Vyukov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+aRqG8i1WUKAF925aqN9Nrg43YE1AjGzzLC5hZs4ZawDw@mail.gmail.com \
--to=dvyukov@google.com \
--cc=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=dwindsor@gmail.com \
--cc=elena.reshetova@intel.com \
--cc=ishkamiel@gmail.com \
--cc=keescook@chromium.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@mjdsystems.ca \
--cc=mingo@kernel.org \
--cc=mjurczyk@google.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+6b495100f17ca8554ab9@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@virtuozzo.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).